Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trivia in root of file #404

Merged
merged 2 commits into from Nov 10, 2019
Merged

Trivia in root of file #404

merged 2 commits into from Nov 10, 2019

Conversation

BrianFreemanAtlanta
Copy link
Contributor

Link to issue(s) this covers
I was working on #333 which can now be closed. It turns out it was fixed as part of #386.

Problem

comments in the start of the file were being lost.

Solution

  • Here are 2 tests showing the issue is resolved
  • The second test may not be needed. It shows if there is leading spaces on the comments they are trimmed during the conversion
  • At least one test covering the code changed

@GrahamTheCoder GrahamTheCoder merged commit 3afa65d into icsharpcode:master Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BrianFreemanAtlanta @GrahamTheCoder