Reference Mono.Cecil using a PackageReference #1001
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current submodule and bundling approach causes problems for consumers of ICSharpCode.Decompiler due to the embedding of a "non-standard" build of Mono.Cecil.dll. This pull request modifies the references to use
PackageReference
instead, and declare a NuGet dependency on the Mono.Cecil package on NuGet.For this pull request, I did not remove the submodule itself. It's possible that developers have local branches in the submodule and would like to continue working with those branches, so I decided to leave that decision for a future pull request.
This pull request is very similar to #998. Specific differences are:
<PackageReference>
in a few places, so there are fewer explicit references to Mono.Cecil