Run tests with different versions of Roslyn #2194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgrunwald
reviewed
Oct 23, 2020
| @@ -191,7 +191,7 @@ private class Change : IChange | |||
| public event EventHandler AutomaticEventWithInitializer = delegate { | |||
| }; | |||
|
|
|||
| #if ROSLYN | |||
| #if CS73 | |||
There was a problem hiding this comment.
I guess the tuple needs CS70; but the dynamic test only needs roslyn?
siegfriedpammer
force-pushed
the
multi-roslyn-tests
branch
from
1f45b11
to
a2f3296
Compare
siegfriedpammer
force-pushed
the
multi-roslyn-tests
branch
from
a2f3296
to
be57dc4
Compare
ElektroKill
added a commit
to dnSpyEx/ILSpy
that referenced
this pull request
Aug 10, 2021
Run tests with different versions of Roslyn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2141 by downloading precompiled Roslyn compiler packages from https://www.nuget.org/packages/Microsoft.Net.Compilers. Note: these packages are marked as deprecated, we will have to switch to Microsoft.Net.Compilers.Toolset packages for newer versions of Roslyn.
Options we considered:
/sharedswitch, which allows us to use the VBCSCompiler.exe compiler server.