Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Visual Basic Async Await state machine decompilation #2853

Merged
merged 4 commits into from
Dec 2, 2022

Conversation

ElektroKill
Copy link
Contributor

Link to issue(s) this covers:
N/A

Problem

ILSpy did not support async await state machines generated by both the legacy Visual Basic compiler as well as Roslyn Visual Basic compiler.

The code generation differed for the state machine creation code, the placement of the doFinallyBodies initial assignment, additional calls to VB-specific methods in the catch handler, additional stack slots, and different order of field assignments in the resume blocks.

Solution

  • Adjust the async await decompilation logic to handle the different code generation properly
  • Enable, fix and extend the VBPretty test for Async Await.

@siegfriedpammer
Copy link
Member

Thank you very much for your contribution!

LGTM

@siegfriedpammer siegfriedpammer merged commit 8e48f63 into icsharpcode:master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants