[Completion] Fixed bug.

ICSharpCode.NRefactory.CSharp/Completion/CSharpCompletionEngine.cs

@@ -2410,7 +2410,9 @@ out trr
 					}
 					if (member is IType) {
 						if (resolveResult is TypeResolveResult || includeStaticMembers) {
-							result.AddType ((IType)member, false);
+							if (!lookup.IsAccessible(member, isProtectedAllowed))
+								continue;
+							result.AddType((IType)member, false);
 							continue;
 						}
 					}

ICSharpCode.NRefactory.Tests/CSharp/CodeCompletion/CodeCompletionBugTests.cs

@@ -224,6 +224,13 @@ public IEnumerable<ICompletionData> CreatePreProcessorDefinesCompletionData ()
 			loader.IncludeInternalMembers = true;
 			return loader.LoadAssemblyFile(typeof(System.ComponentModel.BrowsableAttribute).Assembly.Location);
 		});
+		static readonly Lazy<IUnresolvedAssembly> systemXmlLinq = new Lazy<IUnresolvedAssembly>(
+			delegate {
+			var loader = new CecilLoader();
+			loader.IncludeInternalMembers = true;
+			return loader.LoadAssemblyFile(typeof(System.Xml.Linq.XElement).Assembly.Location);
+		});
+
 
 		static readonly Lazy<IUnresolvedAssembly> mscorlib = new Lazy<IUnresolvedAssembly>(
 			delegate {
@@ -259,7 +266,7 @@ public static CSharpCompletionEngine CreateEngine(string text, out int cursorPos
 			var doc = new ReadOnlyDocument(editorText);
 
 			IProjectContent pctx = new CSharpProjectContent();
-			var refs = new List<IUnresolvedAssembly> { mscorlib.Value, systemCore.Value, systemAssembly.Value };
+			var refs = new List<IUnresolvedAssembly> { mscorlib.Value, systemCore.Value, systemAssembly.Value, systemXmlLinq.Value };
 			if (references != null)
 				refs.AddRange (references);
 
@@ -313,7 +320,7 @@ Tuple<ReadOnlyDocument, CSharpCompletionEngine> GetContent(string text, SyntaxTr
 		{
 			var doc = new ReadOnlyDocument(text);
 			IProjectContent pctx = new CSharpProjectContent();
-			pctx = pctx.AddAssemblyReferences(new [] { CecilLoaderTests.Mscorlib, CecilLoaderTests.SystemCore });
+			pctx = pctx.AddAssemblyReferences(new [] { mscorlib.Value, systemAssembly.Value, systemCore.Value, systemXmlLinq.Value });
 			var unresolvedFile = syntaxTree.ToTypeSystem();
 
 			pctx = pctx.AddOrUpdateFiles(unresolvedFile);
@@ -5634,5 +5641,36 @@ void Bar()
 				Assert.IsNull(provider.Find("InternalStringComparer"));
 			});
 		}
+
+		/// <summary>
+		/// Bug 6237 - Code completion includes private code 
+		/// </summary>
+		[Test()]
+		public void TestBug6237 ()
+		{
+
+			CombinedProviderTest(
+				@"
+namespace bug
+{
+   public class TestClass
+    {
+        void Bar()
+        {
+            $System.Xml.Linq.XElement.$
+        }
+    }
+}
+
+", provider => {
+				Assert.IsTrue (provider.Count > 0);
+				// it's likely to be mono specific.
+				foreach (var data in provider.Data) {
+					Assert.IsFalse (data.DisplayText.StartsWith ("<"), "Data was:"+ data.DisplayText);
+				}
+			});
+		}
+
+
 	}
 }