Correctly handle Unicode strings #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piksel
added
ready
TalAloni
added a commit
to TalAloni/SharpZipLib
that referenced
this pull request
Oct 27, 2018
…nicode is set This is to amend PR icsharpcode#255, note that before this patch the UnicodeText flag is set in the ZipEntry constructor, after we have already read the name as non-unicode, which is obviously not right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 2c458be replaced the default code page with UTF-8, but ZipEntry.IsUnicodeText is still set to
falseby default.This makes it the default behaviour of SharpZipLib to create zip files that claim they are not coded using UTF-8 (but instead with what is presumed to be the locale default code page), but still containing UTF-8 encoded file names.
This PR will rectify that by setting the
ZipEntry.IsUnicodeTextdefault based on whatZipStrings.CodePage(previously calledZipConstants.DefaultCodePage) is set to.This also moves the string transcoding from
ZipConstantstoZipStringsas I could not let it stay inside a class obviously named for another purpose.There are still wrappers for all public functionality that provides full backwards compability.
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.