Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the project file to be added to a VS 2013 solution #66

Merged
merged 1 commit into from
Feb 5, 2015
Merged

Allow the project file to be added to a VS 2013 solution #66

merged 1 commit into from
Feb 5, 2015

Conversation

benjamb
Copy link
Contributor

@benjamb benjamb commented Feb 3, 2015

When attempting to use ICSharpCode.SharpZLib.csproj as part of a VS 2013 solution, an error occurs informing you that a one-way upgrade is required for compatibility. Adding the ToolsVersion property to the project file allows the project to be added to more recent VS solutions in a way that shouldn't break existing builds or solutions.

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

jfreilly added a commit that referenced this pull request Feb 5, 2015
Allow the project file to be added to a VS 2013 solution
@jfreilly jfreilly merged commit 9478d50 into icsharpcode:master Feb 5, 2015
@benjamb benjamb deleted the benbrown/vs2013-csproj branch February 6, 2015 10:01
@McNeight McNeight mentioned this pull request Apr 6, 2016
@benjamb
Copy link
Contributor Author

benjamb commented Apr 7, 2016

#103: 👍

@McNeight
Copy link
Contributor

McNeight commented Apr 7, 2016

Ben,

Thanks for responding, and thanks for your contribution.

-Neil

@McNeight McNeight added enhancement Feature request or other improvements of existing functionality build labels Apr 14, 2016
@McNeight McNeight modified the milestone: 1.0 May 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build enhancement Feature request or other improvements of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants