Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and enhancements for issues discovered in testing of beta release 1.2.1 #163

Merged
merged 10 commits into from
Jul 29, 2021

Conversation

rogerfraser
Copy link
Member

Overview

This pull request introduces the following fixes and code enhancements:

Fixes

  • Adress a lingering renaming issue in import relating to the renaming of sites in SNX files with discontinuities. Specifically, this fix ensures SNX sites are renamed using the start of the observation window defining the period up to which a discontinuity has been identified, rather than the date of the first SNX solution (which may vary depending on GNSS analyis).
  • Address a DynaML station name parsing issue caused when two different station names are provided within the one <DnaStation> record, as shown below.
  <DnaStation>
    <Name>station-name-a</Name>
    <StationCoord>
      <Name>station-name-b</Name>
      ...
    <StationCoord>
  </DnaStation>

Enhancements

  • In make_dynadjust_gcc.sh, streamline build behaviour across clone and no-clone options.
  • In install_dynadjust_prerequisites.sh, clean up temporary folders created when downloading prerequisites.
  • Update (GitHub Actions and Travis) CI/CD scripts to take advantage of changes to make_dynadjust_gcc.sh.

@coveralls
Copy link
Collaborator

coveralls commented Jul 29, 2021

Coverage Status

Coverage decreased (-0.01%) to 82.127% when pulling 47b1baf on rogerfraser:master into 720574b on icsm-au:master.

@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #163 (47b1baf) into master (213ed3e) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
- Coverage   82.37%   82.35%   -0.02%     
==========================================
  Files         117      117              
  Lines       32448    32445       -3     
==========================================
- Hits        26729    26721       -8     
- Misses       5719     5724       +5     
Impacted Files Coverage Δ
dynadjust/dynadjust/dnaimport/dnaparser_pimpl.cxx 84.28% <ø> (-0.03%) ⬇️
dynadjust/include/io/dnaiosnxread.cpp 59.77% <66.66%> (+0.19%) ⬆️
...t/dynadjust/dnaadjustwrapper/dnaadjustprogress.cpp 72.37% <0.00%> (-4.42%) ⬇️
dynadjust/dynadjust/dnaadjust/dnaadjust.cpp 89.17% <0.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 213ed3e...47b1baf. Read the comment docs.

@rogerfraser rogerfraser merged commit 2a553ec into icsm-au:master Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants