Skip to content

Commit

Permalink
Enabled Paul Revere signups for NOR, Added comments to my earlier cha…
Browse files Browse the repository at this point in the history
…nges

- enabled Paul Revere notifications in TabularView, MiniSectionTable, and SectionTable
- Added comments for clarity in OptOutPopover.js and App.js
  • Loading branch information
fatimazali committed Jun 23, 2019
1 parent f8e3e32 commit f552421
Show file tree
Hide file tree
Showing 8 changed files with 142 additions and 168 deletions.
288 changes: 125 additions & 163 deletions package-lock.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"react-color": "^2.17.3",
"react-device-detect": "1.6.1",
"react-dom": "^16.8.6",
"react-ga": "^2.5.7",
"react-ga": "^2.6.0",
"react-messenger-customer-chat": "^0.7.2",
"react-number-format": "^4.0.7",
"react-scripts": "^2.1.8",
Expand Down
2 changes: 1 addition & 1 deletion src/components/App/App.js
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,7 @@ class App extends Component {
onSave={this.handleSave}
isDesktop={this.state.isDesktop}
/>

{/* Send current user data to Popover to update currently selected website options */}
<OptOutPopover
handleSelectRMP={this.handleSelectRMP}
handleSelectEE={this.handleSelectEE}
Expand Down
3 changes: 2 additions & 1 deletion src/components/App/TabularView.js
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,8 @@ class TabularView extends Component {
};

statusforFindingSpot = (section, classCode, termName, name) => {
if (section === 'FULL')
if (section === 'FULL' || section === 'NewOnly')
// Enable user to register for Paul Revere notifications
return (
<Notification
termName={termName}
Expand Down
2 changes: 2 additions & 0 deletions src/components/CoursePane/Instructors.js
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,8 @@ class Instructors extends React.Component {
onClose={this.handlePopoverClose}
disableRestoreFocus
>
{' '}
{/* Display current selection of website to view staff evaluations on */}
{this.props.destination === 'eatereval' ? (
<Typography>Links to EaterEval; See Setting</Typography>
) : (
Expand Down
3 changes: 2 additions & 1 deletion src/components/CoursePane/MiniSectionTable.js
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,8 @@ class ScheduleAddSelector extends Component {
};

statusforFindingSpot = (section, classCode) => {
if (section === 'FULL')
if (section === 'FULL' || section === 'NewOnly')
// Enable user to register for Paul Revere notifications
return (
<Notification
termName={this.props.termName}
Expand Down
7 changes: 7 additions & 0 deletions src/components/CoursePane/OptOutPopover.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ import toRenderProps from 'recompose/toRenderProps';
import withState from 'recompose/withState';
import { Settings } from '@material-ui/icons';

{
/* Material UI Popover at top toolbar, allows users to select whether staff names link out to RateMyProfessors.com
or UCI's EaterEvals. */
}

const WithState = toRenderProps(withState('anchorEl', 'updateAnchorEl', null));

const styles = (theme) => ({
Expand All @@ -38,6 +43,8 @@ function OptOutPopover(props) {
color="inherit"
style={{ marginLeft: sep, marginRight: sep }}
>
{' '}
{/* For desktop mode only*/}
<Settings />
{props.isDesktop ? (
<Typography color="inherit">&nbsp;&nbsp;Settings</Typography>
Expand Down
3 changes: 2 additions & 1 deletion src/components/CoursePane/SectionTable.js
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,8 @@ class SectionTable extends Component {
};

statusforFindingSpot = (section, classCode) => {
if (section === 'FULL')
if (section === 'FULL' || section === 'NewOnly')
// Enable user to register for Paul Revere notifications
return (
<Notification
full={section}
Expand Down

0 comments on commit f552421

Please sign in to comment.