Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always display GPA Column #980

Merged
merged 5 commits into from
May 9, 2024
Merged

Always display GPA Column #980

merged 5 commits into from
May 9, 2024

Conversation

MinhxNguyen7
Copy link
Collaborator

Summary

  • The GPA column will now be shown on both the search and added panes.
  • Remove vestigial logic in the stores which enabled the disabling of the columns in the added pane.
  • Fix a bug that broke the column toggle buttons. This was broken before, but no one noticed.

Test Plan

  • Check that the GPA column shows up in both panes.
  • Check that the column toggles work as expected.

Issues

Future Followup

  • Would be nice for the column filtering to persist between page loads.

@MinhxNguyen7 MinhxNguyen7 self-assigned this May 5, 2024
@github-actions github-actions bot requested a review from Douglas-Hong May 5, 2024 08:05
@MinhxNguyen7 MinhxNguyen7 added enhancement Improvements to the user experience bug labels May 5, 2024
KevinWu098
KevinWu098 requested changes May 6, 2024
View reviewed changes
Copy link
Member

@KevinWu098 KevinWu098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Lookin' forward to having GPA column in the Added section 😋

Just one chore and we're good to go!

apps/antalmanac/src/components/RightPane/CoursePane/CoursePaneButtonRow.tsx Outdated Show resolved Hide resolved
@MinhxNguyen7 MinhxNguyen7 requested review from KevinWu098 and removed request for Douglas-Hong May 9, 2024 21:11
KevinWu098
KevinWu098 approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@KevinWu098 KevinWu098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MinhxNguyen7 MinhxNguyen7 merged commit be531ef into main May 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinWu098 KevinWu098 KevinWu098 approved these changes

Assignees

@MinhxNguyen7 MinhxNguyen7

Labels
bug enhancement Improvements to the user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show GPA column on Added Page
2 participants
@MinhxNguyen7 @KevinWu098