Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide page on ergoCub joint specs #184

Closed
divyashah opened this issue Nov 22, 2021 · 7 comments · Fixed by #297
Closed

Provide page on ergoCub joint specs #184

divyashah opened this issue Nov 22, 2021 · 7 comments · Fixed by #297
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@divyashah
Copy link
Member

divyashah commented Nov 22, 2021

I observed that the details for a few of the joints in iCub 3 joints specs, in particular Motor type and Harmonic drive, are not up to date with the latest CAD model. I believe the documentation has not been updated after some of the latest upgrades on iCub 3.

I noticed mainly the following inconsistencies:

How shall we proceed in order to update the iCub 3 joints specs documentation ??
cc @fiorisi @pattacini


⚠️ We changed the original scope of this issue as per #184 (comment).

@pattacini
Copy link
Member

How shall we proceed in order to update the iCub 3 joints specs documentation ??

Hi @divyashah

PR's are more than welcome.
Just calling for @salvi-mattia review as well.

@pattacini
Copy link
Member

Hi @divyashah

Would you be willing to contribute on this?

@divyashah
Copy link
Member Author

Hi @divyashah

Would you be willing to contribute on this?

Hi @pattacini

Yes, I can contribute on this.
However, should I update now modify the page on iCub3 itself or shall we create a new page for ergoCub1 ?

@pattacini
Copy link
Member

pattacini commented Jul 31, 2023

Yes, I can contribute on this.

Thanks heaps @divyashah! Very much appreciated.

However, should I update now modify the page on iCub3 itself or shall we create a new page for ergoCub1 ?

My hunch is that we should move to ergoCub, whose joint specs are missing in the documentation. Such a page is very overdue ⏰

I reckon that to start with, it'd be sufficient to create a page similar to that of iCub 3 but without images, to keep things simple.

What do you think?

cc @maggia80 @fiorisi @salvi-mattia @traversaro

@pattacini pattacini added the documentation Improvements or additions to documentation label Jul 31, 2023
@divyashah
Copy link
Member Author

My hunch is that we should move to ergoCub, whose joint specs are missing in the documentation. Such a page is very overdue ⏰

I reckon that to start with, it'd be sufficient to create a page similar to that of iCub 3 but without images, to keep things simple.

Yes, sounds good. We can add images later. I will start preparing a draft on this.

@pattacini
Copy link
Member

pattacini commented Jul 31, 2023

Superb!

If it's your first-time contribution, I'd suggest you rely on this workflow that uses forks to generate the temporary website:

@pattacini
Copy link
Member

Hi @divyashah
While addressing this task, please account for #175 (comment).

cc @traversaro

@pattacini pattacini changed the title Update motor type and harmonic drive details on iCub 3 joint documentation Provide ergoCub page on joint specs Jul 31, 2023
@pattacini pattacini changed the title Provide ergoCub page on joint specs Provide page on ergoCub joint specs Jul 31, 2023
@pattacini pattacini linked a pull request Aug 7, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants