Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAIP-10 #2
base: main
Are you sure you want to change the base?
CAIP-10 #2
Changes from all commits
856bb50
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe accounts are tightly bound to the ledger to which they belong.
I'd say the ledger principal should be a part of the address.
Something like
or, if we use path-like addressing, something like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CAIP-10 limits (for reasons unknown to me) the length of a full account identifier to 128 characters. I'm not sure what the consequences are if ICP were to violate that part of the spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Ledger & Tokenization Working Group agreed on a textual representation for accounts; here is the spec: https://github.com/dfinity/ICRC-1/pull/98/files#diff-cf72e3d78c946edc91e3b8d499b8c7a7e894daaca1922e33b9ab7e40544e5030
I hope we won't need to invent a new encoding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will look into this by next WG session.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add an example that includes the principal an a subaccount? Or do we hit length constraints again, making this impossible?
If so, we could maybe keep the current scheme for the main account (because it's nice to directly have the principal in there) and the have a hash that includes the subaccount identifier for subaccounts?