New feature: local cache #35

icyleaf · 2018-08-30T10:58:38Z

Related to #24

icyleaf · 2018-08-30T11:03:56Z

Update a little test:

Complie source code and get request "http://httpbin.ogr/anything"

$ time crystal main.cr
crystal main.cr  6.79s user 1.21s system 197% cpu 4.039 total

$ time crystal main.cr
crystal main.cr  2.18s user 0.50s system 133% cpu 2.006 total

It speed up 3x fast!

j8r

That's a good feature, this also needs specs.
I find Halite::Features and Halite::Feature are quite confusing.
I think having directly Halite::Logger and Halite::Cache would clearer.

j8r · 2018-08-30T14:52:19Z

src/halite/features/cache.cr

+  # r.headers # => {..., "X-Cached-At" => "2018-08-30 10:41:14 UTC", "X-Cached-By" => "Halite", "X-Cached-Expires-At" => "2018-08-30 10:41:19 UTC", "X-Cached-Key" => "2bb155e6c8c47627da3d91834eb4249a"}}
+  # ```
+  class Cache < Feature
+    DEFAULT_PATH = "cache/"


It's not a good idea to create a directory in the root directory, at least create in /tmp
Maybe a better approach would be:

On a new Cache object creation, a temporary directory will be created with https://crystal-lang.org/api/master/Tempfile.html (Tempfile.new("halite-cache").path)

Add a finalize method that will delete the directory when the Object is destructed (#delete)

Note: the API will likely change in the next release crystal-lang/crystal#6485

This commit just a simple test, it was not following my spec. May be push it early.

j8r

Tempfile can be used for the cache

icyleaf · 2018-08-31T03:05:36Z

I find Halite::Features and Halite::Feature are quite confusing.
I think having directly Halite::Logger and Halite::Cache would clearer.

That's my problem, i did not design the picture enough, I'm working on it, i will removing Features and let feature under Halite module.

It will a new PR to do (#36)

…ture under Halite and some method changes. Feature: - `Halite::Features::Logger` to `Halite::Logger` - `Halite::Features.register` to `Halite.register_feature` - `Halite::Features[]/[]?` to `Halite.features/features?` - `Halite::Features.avaiables` to `Halite.has_feature?` - `Halite::Feature::Interceptor::Chain` to `Halite::Feature::Chain`

…logger format

…d merge Halite::MimeTypes.register_adapter/register_alias into Halite::MimeType.register

…hmark to json format

icyleaf · 2018-08-31T10:10:00Z

@j8r I was updated new design about local cache, please review the top content at #24. With new design, it does not use Tempfile.

…file

Halite.use("cache", file: "github_users.json").get("https://api.github.com/v3/users")

…cal-cache

icyleaf

Ready to merge 🎉

ghost assigned icyleaf Aug 30, 2018

ghost added the in progress label Aug 30, 2018

feat(cache): add simple local cache support

2eee140

icyleaf force-pushed the feature/local-cache branch from c91033f to 2eee140 Compare August 30, 2018 10:59

icyleaf mentioned this pull request Aug 30, 2018

feature: local cache #24

Closed

j8r reviewed Aug 30, 2018

View reviewed changes

icyleaf added 9 commits August 31, 2018 17:59

refactor(logger): Renamed feature logger to logging to better accept …

fd1402f

…logger format

refactor(mime_type): Rename Halite::MimeTypes to Halite::MimeType, an…

8f06c87

…d merge Halite::MimeTypes.register_adapter/register_alias into Halite::MimeType.register

refactor(mime_type): Rename Halite::MimeTypes to Halite::MimeType, an…

c2d997d

…d merge Halite::MimeTypes.register_adapter/register_alias into Halite::MimeType.register

fix(logging): Remove instance Logging with format

f62437e

feat(logging): apply skip_request_body, skip_response_body, skip_benc…

44c8f44

…hmark to json format

test: fix ci

478f087

doc: update new changes in README

72880e1

chore: clean up

655ad4d

icyleaf force-pushed the feature/local-cache branch from 1b614ba to 423c4db Compare August 31, 2018 09:59

fix(cache): keep with new feature spec

8842c48

icyleaf force-pushed the feature/local-cache branch from 423c4db to 8842c48 Compare August 31, 2018 10:00

icyleaf added 7 commits August 31, 2018 18:42

feat(cache): store cache into a directory with metdata file and body …

7f99953

…file

doc: update cache comment

195d5ac

fix merge conflict

7e17d02

test: add cache feature spec

990b3bd

test(cache): add more feature cache tests

229486f

test(cache): remove path writable test

c1a4555

feat(cache): load cache from file support

f220ba4

Halite.use("cache", file: "github_users.json").get("https://api.github.com/v3/users")

icyleaf added 3 commits September 3, 2018 17:13

Merge branch 'fix/reduce-response-when-use-intercept' into feature/lo…

266adb4

…cal-cache

fix(cache): expires compare use utc time

35563f2

refactor(cache): cache default path change to /tmp/halite/cache

fe4b5b7

icyleaf commented Sep 3, 2018

View reviewed changes

icyleaf added enhancement and removed in progress labels Sep 3, 2018

icyleaf merged commit b36866b into master Sep 3, 2018

icyleaf deleted the feature/local-cache branch September 3, 2018 09:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New feature: local cache #35

New feature: local cache #35

icyleaf commented Aug 30, 2018

icyleaf commented Aug 30, 2018 •

edited

j8r left a comment •

edited

j8r Aug 30, 2018 •

edited

icyleaf Aug 31, 2018

j8r left a comment

icyleaf commented Aug 31, 2018 •

edited

icyleaf commented Aug 31, 2018

icyleaf left a comment

New feature: local cache #35

New feature: local cache #35

Conversation

icyleaf commented Aug 30, 2018

icyleaf commented Aug 30, 2018 • edited

j8r left a comment • edited

Choose a reason for hiding this comment

j8r Aug 30, 2018 • edited

Choose a reason for hiding this comment

icyleaf Aug 31, 2018

Choose a reason for hiding this comment

j8r left a comment

Choose a reason for hiding this comment

icyleaf commented Aug 31, 2018 • edited

icyleaf commented Aug 31, 2018

icyleaf left a comment

Choose a reason for hiding this comment

icyleaf commented Aug 30, 2018 •

edited

j8r left a comment •

edited

j8r Aug 30, 2018 •

edited

icyleaf commented Aug 31, 2018 •

edited