Refactor to keep feature simple

[icyleaf]

So sorry to refactor, i hope you are not use unstable master branch.

Feature:

• Halite::Features::Logger to Halite::Logger
• Halite::Features.register to Halite.register_feature
• Halite::Features[]/[]? to Halite.features/features?
• Halite::Features.avaiables to Halite.has_feature?
• Halite::Feature::Interceptor::Chain to Halite::Feature::Chain

Logger

• Rename Halite::Logger to Halite::Logging to better understand
• Rename feature name "logger" to "logging"

This changes was not impact the usage with .logger method in Chainable module.

MimeType

• Rename Halite::MimeTypes to Halite::MimeType
• Merge Halite::MimeTypes.register_adapter/register_alias into Halite::MimeType.register

[j8r]

I found the name Halite::Logger fine, line in the stdlib https://github.com/crystal-lang/crystal/blob/master/src/logger.cr (the name is also shorter)

The main concern for me was the extensive use of class variables, particularly in modules.
I haven't tested yet, but there are good chances this variables are shared across all Halite Objects.
We may want to have independent Objects when spawning Fibers for example.
For example one that log to STDOUT, the other at the same time downloading in the background and log to a file.

What do you think, is it the desired behavior?

[j8r]

Also a thought, what do you think of defining features and behaviors in properties in a Halite or a Halite::Client Object instead of a Hash? This would be quite a lot more efficient, and may solve the above issue.

[icyleaf]

I tried use feaure class as argument, but it will be complex, eg:

Halite.use(Halite::Logging.new(logger: Halite::Logging::JSON.new(skip_response_body: true)))

[icyleaf]

We may want to have independent Objects when spawning Fibers for example.
For example one that log to STDOUT, the other at the same time downloading in the background and log to a file.

This only apply in monitoring case, if some feature changed value of request, we can not apply it to the other featues when spawning.

[icyleaf]

It Seems ready to merge.