Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace kbn_sankey_vis with vega or transform #147

Closed
mmguero opened this issue Jan 25, 2023 · 6 comments
Closed

replace kbn_sankey_vis with vega or transform #147

mmguero opened this issue Jan 25, 2023 · 6 comments
Assignees
Labels
dashboards Relating to Malcolm's OpenSearch Dashboards interface enhancement New feature or request external Depends on a bug or feature external to this project
Milestone

Comments

@mmguero
Copy link
Collaborator

mmguero commented Jan 25, 2023

EDIT: see my latest comments below for a working version of this, I think now it's just to implement and tweak

Malcolm's sankey visualizations are using my "osd_sankey_vis" fork of the uniberg/kbn_sankey_vis. However, opensearch compatibility is not something that's upstream and it's difficult to keep my (somewhat hackneyed) fork up-to-date.

I think this can be done, however, using Vega. See:

@mmguero mmguero added enhancement New feature or request external Depends on a bug or feature external to this project dashboards Relating to Malcolm's OpenSearch Dashboards interface labels Jan 25, 2023
@mmguero mmguero self-assigned this Jan 25, 2023
@mmguero
Copy link
Collaborator Author

mmguero commented Feb 1, 2023

Here's an example of a "working" sankey, but I'm not sure how to get the table/composite aggregation to order the size by bucket/node size.

action.hjson.txt

@mmguero
Copy link
Collaborator Author

mmguero commented Feb 2, 2023

lguillaud/osd_transform_vis is also an option.

@mmguero mmguero changed the title replace kbn_sankey_vis with vega replace kbn_sankey_vis with vega or transform Feb 2, 2023
@mmguero mmguero removed their assignment May 31, 2023
@mmguero
Copy link
Collaborator Author

mmguero commented Nov 7, 2023

@mmguero
Copy link
Collaborator Author

mmguero commented Nov 7, 2023

this actually seems to work pretty well:

sankey.vega.txt

@mmguero mmguero modified the milestones: v23.12.0, v23.11.0 Nov 14, 2023
@mmguero
Copy link
Collaborator Author

mmguero commented Nov 14, 2023

This is a work-in-progress of a three-level sankey, don't have it quite right but it's close. I may just split it into two for now. The only one that used a three-tier graph was the actions and results, and actually thinking about it having it split into 2 might be better since otherwise you have to have action:* AND result:* (which is not the case for all protocols, so some are being left out).

sankey.vega_three.txt

@mmguero
Copy link
Collaborator Author

mmguero commented Nov 14, 2023

Done. Things that could still be improved slightly:

  • text color for dark mode
  • three level sankey (see above comment)

But for the most part it's even better than before, because now selection results in applying a filter.

mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Nov 14, 2023
@mmguero mmguero closed this as completed Nov 14, 2023
@mmguero mmguero self-assigned this Nov 15, 2023
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Nov 28, 2023
This was referenced Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboards Relating to Malcolm's OpenSearch Dashboards interface enhancement New feature or request external Depends on a bug or feature external to this project
Projects
Status: Released
Development

No branches or pull requests

1 participant