Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LDAP Bind credentials world readable in docker #47

Closed
mmguero opened this issue Jun 30, 2021 · 2 comments
Closed

LDAP Bind credentials world readable in docker #47

mmguero opened this issue Jun 30, 2021 · 2 comments
Assignees
@mmguero
Labels
nginx Relating to Malcolm's use of nginx security Related to issues with bearing on the security of Malcolm itself

Comments

@mmguero
Copy link
Collaborator

mmguero commented Jun 30, 2021

created from cisagov#171

🐛 Summary

What's wrong? Please be specific.
LDAP Bind credentials in this file are readable by anyone. Can we put some permissions on the file when it gets created in the nginx entrypoint?

-rw-r--r-- /var/lib/docker/overlay2/*****/diff/etc/nginx/nginx_ldap_rt.conf

To reproduce

Steps to reproduce the behavior:

  1. Standard build with LDAP
  2. Grep overlay2 for bind credentials

Expected behavior

Readable only by user running nginx

What did you expect to happen that didn't?

Any helpful log output or screenshots

Paste the results here:



Add any screenshots of the problem here.

      		
    

      
  





        


            

              
            

        

      


      
    








      

    



      

  
          

  

    
  


  

      

    @mmguero
mmguero



    mentioned this issue
    
      Jun 30, 2021
    





  


  

      
  
  Closed

  







  









      

  
      



  

  @mmguero





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

      

  
    Collaborator


      

  Author


  


  

    

      

      
            mmguero
  

      

      

      commented


        Jun 30, 2021


      
    


  





      


        


  
    

      
          
Thanks @gentoo9ball.


I've pushed a fix up to a development branch that will be merged in here when I do the next release (in the next week or so). See 02e8f53 if you want the details of the patch for your local instance before that.

      		
    

  





        


            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @mmguero
mmguero




              self-assigned this


      Jun 30, 2021

    

  



    

    

      
    

    


      

          @mmguero
mmguero




            added
      

  nginx

  Relating to Malcolm's use of nginx

      

  security

  Related to issues with bearing on the security of Malcolm itself

  labels


      Jun 30, 2021

    

  



  





      

  
      



  

  @mmguero





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

      

  
    Collaborator


      

  Author


  


  

    

      

      
            mmguero
  

      

      

      commented


        Jul 9, 2021


      
    


  





      


        


  
    

      
          
For release in 3.1.1

      		
    

  





        


            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @mmguero
mmguero




            closed this as completed


      Jul 9, 2021

    

  


    


  

  

    
  


  

      

    @mmguero
mmguero



    mentioned this issue
    
      Jul 9, 2021
    





  


  

      
   Merged

  







  




  


  
    
  
  

    
  mmguero 

      added a commit
        to cisagov/Malcolm
      that referenced
      this issue

    
      Jul 9, 2021
    
    

      


  

    

      


  

      
        @mmguero
  





      

        
          3.1.1 development (#172)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          3a35306
        
      

    

  

    

      
v3.1.1 development

* New features
  * ["Best Guess" Fingerprinting for ICS Protocols](idaholab#49) - In an effort to help identify more ICS traffic, Malcolm can use "buest guess" method based on transport protocol (e.g., TCP or UDP) and port(s) to categorize potential traffic communicating over some ICS protocols without full parser support. This feature involves a [mapping table](https://github.com/idaholab/Malcolm/blob/master/zeek/config/guess_ics_map.txt) and a [Zeek script](https://github.com/idaholab/Malcolm/blob/master/zeek/config/guess.zeek) to look up the transport protocol and destination and/or source port to make a best guess at whether a connection belongs to one of those protocols. These potential ICS communications are categorized by vendor where possible. The list of ICS protocols' ports was adapted from various public sources, including, but not limited to, [Grassmarlin](https://github.com/nsacyber/GRASSMARLIN/tree/master/GM3/data/fingerprint)'s fingerprints and [ITI/ICS-Security-Tools](https://github.com/ITI/ICS-Security-Tools/blob/master/protocols/PORTS.md)' list of Control Systems Ports.

* Improvements and bug fixes
  * Allow configuring the number of concurrent requests for ClamAV scanning, Yara and Capa via environment variables (`CLAMD_MAX_REQUESTS`, `YARA_MAX_REQUESTS` and `CAPA_MAX_REQUESTS`)
  * Zeek plugins to detect [CVE-2021-31166](https://github.com/corelight/CVE-2021-31166) and [pingback](https://github.com/corelight/pingback) vulnerabilities
  * Move creation of custom fields and views to [Arkime's config.ini](https://arkime.com/settings#custom-fields)
  * LDAP bind credentials world readable in docker (idaholab#47 and #171)
  * Deny access to uploaded files (#170)

* Version bumps
  * Yara to 4.1.1
  * Zeek to 4.0.3
  * Spicy to 1.1.0
  * Alpine to 3.14
  * NGINX to 1.20.1
  * Linux kernel to 5.10 (for ISO installs)
  * urllib3 to 1.26.5 (#169)

    




    

  




  


  
    
  
  

    
  mmguero 

      added a commit
      that referenced
      this issue

    
      Jul 9, 2021
    
    

      


  

    

      


  

      
        @mmguero
  





      

        
          v3.1.1 development, merged from cisagov#172
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          2cd4cdf
        
      

    

  

    

      
Merge remote-tracking branch 'cisa/master'

* New features
  * ["Best Guess" Fingerprinting for ICS Protocols](#49) - In an effort to help identify more ICS traffic, Malcolm can use "buest guess" method based on transport protocol (e.g., TCP or UDP) and port(s) to categorize potential traffic communicating over some ICS protocols without full parser support. This feature involves a [mapping table](https://github.com/idaholab/Malcolm/blob/master/zeek/config/guess_ics_map.txt) and a [Zeek script](https://github.com/idaholab/Malcolm/blob/master/zeek/config/guess.zeek) to look up the transport protocol and destination and/or source port to make a best guess at whether a connection belongs to one of those protocols. These potential ICS communications are categorized by vendor where possible. The list of ICS protocols' ports was adapted from various public sources, including, but not limited to, [Grassmarlin](https://github.com/nsacyber/GRASSMARLIN/tree/master/GM3/data/fingerprint)'s fingerprints and [ITI/ICS-Security-Tools](https://github.com/ITI/ICS-Security-Tools/blob/master/protocols/PORTS.md)' list of Control Systems Ports.

* Improvements and bug fixes
  * Allow configuring the number of concurrent requests for ClamAV scanning, Yara and Capa via environment variables (`CLAMD_MAX_REQUESTS`, `YARA_MAX_REQUESTS` and `CAPA_MAX_REQUESTS`)
  * Zeek plugins to detect [CVE-2021-31166](https://github.com/corelight/CVE-2021-31166) and [pingback](https://github.com/corelight/pingback) vulnerabilities
  * Move creation of custom fields and views to [Arkime's config.ini](https://arkime.com/settings#custom-fields)
  * LDAP bind credentials world readable in docker (#47 and cisagov#171)
  * Deny access to uploaded files (cisagov#170)

* Version bumps
  * Yara to 4.1.1
  * Zeek to 4.0.3
  * Spicy to 1.1.0
  * Alpine to 3.14
  * NGINX to 1.20.1
  * Linux kernel to 5.10 (for ISO installs)
  * urllib3 to 1.26.5 (cisagov#169)

    




    

  




  


  
    
  
  

    
  mmguero 

      added a commit
        to mmguero-dev/Malcolm
      that referenced
      this issue

    
      Jul 9, 2021
    
    

      


  

    

      


  

      
        @mmguero
  





      

        
          3.1.1 development (idaholab#172)
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          f140963
        
      

    

  

    

      
v3.1.1 development

* New features
  * ["Best Guess" Fingerprinting for ICS Protocols](idaholab#49) - In an effort to help identify more ICS traffic, Malcolm can use "buest guess" method based on transport protocol (e.g., TCP or UDP) and port(s) to categorize potential traffic communicating over some ICS protocols without full parser support. This feature involves a [mapping table](https://github.com/idaholab/Malcolm/blob/master/zeek/config/guess_ics_map.txt) and a [Zeek script](https://github.com/idaholab/Malcolm/blob/master/zeek/config/guess.zeek) to look up the transport protocol and destination and/or source port to make a best guess at whether a connection belongs to one of those protocols. These potential ICS communications are categorized by vendor where possible. The list of ICS protocols' ports was adapted from various public sources, including, but not limited to, [Grassmarlin](https://github.com/nsacyber/GRASSMARLIN/tree/master/GM3/data/fingerprint)'s fingerprints and [ITI/ICS-Security-Tools](https://github.com/ITI/ICS-Security-Tools/blob/master/protocols/PORTS.md)' list of Control Systems Ports.

* Improvements and bug fixes
  * Allow configuring the number of concurrent requests for ClamAV scanning, Yara and Capa via environment variables (`CLAMD_MAX_REQUESTS`, `YARA_MAX_REQUESTS` and `CAPA_MAX_REQUESTS`)
  * Zeek plugins to detect [CVE-2021-31166](https://github.com/corelight/CVE-2021-31166) and [pingback](https://github.com/corelight/pingback) vulnerabilities
  * Move creation of custom fields and views to [Arkime's config.ini](https://arkime.com/settings#custom-fields)
  * LDAP bind credentials world readable in docker (idaholab#47 and cisagov#171)
  * Deny access to uploaded files (cisagov#170)

* Version bumps
  * Yara to 4.1.1
  * Zeek to 4.0.3
  * Spicy to 1.1.0
  * Alpine to 3.14
  * NGINX to 1.20.1
  * Linux kernel to 5.10 (for ISO installs)
  * urllib3 to 1.26.5 (cisagov#169)

    




    

  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
    @mmguero
  
    mmguero
    

      








      


  


  

    Labels
  



    

      

    nginx

  Relating to Malcolm's use of nginx
  

    security

  Related to issues with bearing on the security of Malcolm itself








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  




              
No branches or pull requests







    
  




        
      

    

  
      

  

    

      1 participant
    

    

        
          @mmguero