Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next patch release #401

Merged
merged 71 commits into from
May 30, 2024
Merged

Next patch release #401

merged 71 commits into from
May 30, 2024

Conversation

MicahGale
Copy link
Collaborator

@MicahGale MicahGale commented Apr 15, 2024 •
edited
Loading

Bug fixes

Documentation

CI/CD

MicahGale and others added 30 commits February 6, 2024 16:58
@MicahGale
Added test for implicit library that causes SyntaxError.
4c17ea7
@MicahGale
Added test that replicated the exact error type in #365
89e2766
@MicahGale
Removed test for actually valid material.
d68c1cf
@MicahGale
Made material tolerant of IsotopesNode and ListNode.
938e254
@MicahGale
Allowed isotope to have no library.
e60138b
@MicahGale
Updated init test to actually work.
e463a08
@MicahGale
Updated material parser rules to work with libraryless ZAID.
8b54488
@MicahGale
Merge branch 'develop' into 365-material-specifications-cannot-unpack…
f3cf542 
…-non-iterable-valuenode-object
@MicahGale
Created test to replicate #206.
e36b6d2
@MicahGale
Moved is_comment to a global namespace
a006a6f
@MicahGale
Made read input detection more robust and efficient.
5c71942
@MicahGale
Fixed read finder to be fault tolerant.
d7402af
@MicahGale
Updated file name parsing
90776f3
@MicahGale
Excluded partial read target from testing.
ec09d2a
@MicahGale
Reformatted with black.
3bc09b6
@MicahGale
Updated doc strings to be valid RST.
b513931
@MicahGale
Create CODE_OF_CONDUCT.md
516bef1
@MicahGale
Made shell of community documents.
6a26abd
@MicahGale
Made draft contribution guide.
2911c16
@MicahGale
Merge branch '375-improve-community-documentation-1' into 375-improve…
681863c 
…-community-documentation
@MicahGale
Started bare changelog.
3024075
@MicahGale
Made changelog test.
c6f26c8
@MicahGale
Added changelog from previous releases
7aae4a5
@MicahGale
Fixed RST syntax.
e908bd4
@MicahGale
Merge branch 'develop' into 206-sly-syntax-error-for-numbers-in-read-…
0fc60bc 
…cards
@MicahGale
Merge branch 'develop' into 365-material-specifications-cannot-unpack…
d1c948c 
…-non-iterable-valuenode-object
@MicahGale
Merge branch 'develop' into 375-improve-community-documentation
5880813
@MicahGale
updated coverage options to make coverall paths work.
727d93c
@MicahGale
Merge branch 'develop' into 206-sly-syntax-error-for-numbers-in-read-…
f3d5a58 
…cards
@MicahGale
Merge branch 'develop' into 365-material-specifications-cannot-unpack…
1611dcb 
…-non-iterable-valuenode-object
@MicahGale
tie to minor release because major release not working.
7191c3b
@MicahGale
Go to next gha release.
867798a
@MicahGale
Included _version in coverage reports.
f5efa6e
@MicahGale
Merge branch 'develop' into 365-material-specifications-cannot-unpack…
5c57061 
…-non-iterable-valuenode-object
@MicahGale
Fix(parser): Fixed parsing materials with implicit library.
2e52934 
Fix bug that can't parse materials with implicit library specification.
@MicahGale
Merge branch 'develop' into 206-sly-syntax-error-for-numbers-in-read-…
97e8172 
…cards
@MicahGale
Merge branch 'develop' into 386-error-with-versioning-without-setupto…
c59dcf7 
…ols-scm-installed
@MicahGale
Updated comment finder with @tjlaboss feedback.
f53c338
@MicahGale
Merge branch 'main' into develop
7caadf8
@MicahGale
Merge branch 'develop' into 206-sly-syntax-error-for-numbers-in-read-…
7bdb7c1 
…cards
@MicahGale
Fix(parser): Fixed how read cards were parsed, and made process faster.
6490485 
Fixing parser error with read card. Se #372.
@MicahGale
Merge branch 'develop' into 386-error-with-versioning-without-setupto…
0593f33 
…ols-scm-installed
@coveralls
Copy link
Collaborator

coveralls commented Apr 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9306605904

Details

  • 71 of 71 (100.0%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 98.223%
Totals Coverage Status
Change from base Build 8695002250: 0.1%
Covered Lines: 5750
Relevant Lines: 5854
💛 - Coveralls

@MicahGale MicahGale requested a review from tjlaboss April 15, 2024 22:30
@MicahGale MicahGale self-assigned this Apr 15, 2024
@MicahGale MicahGale added documentation Improvements or additions to documentation bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". CI/CD labels Apr 15, 2024
@MicahGale MicahGale marked this pull request as ready for review April 15, 2024 22:36
@MicahGale
Fixed syntax error with pip in doc-test
8d5035d
@MicahGale
Delete CODE_OF_CONDUCT.md
4be2781 
At this time this seems to be excessive, and does not need to be enumerated. This does not mean this project is the wild west and anything goes, but rather that issues well be address if and when they occur.
@MicahGale
Doc/CI (all): Merged #375 improving docs and docs CI
f4c3e86 
Impove Community documentation
@MicahGale
Copy link
Collaborator Author

This will be release 0.2.7. Hopefully the CI/CD will deploy this for us, but I am not holding out hope.

@MicahGale MicahGale enabled auto-merge May 30, 2024 17:21
tjlaboss
tjlaboss approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@tjlaboss tjlaboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We ship

@MicahGale MicahGale merged commit f2b68fe into main May 30, 2024
27 checks passed
@tjlaboss
Copy link
Collaborator

Oh duh. The auto-changelog can't update main because it's protected. I should have caught that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjlaboss tjlaboss tjlaboss approved these changes

Assignees

@MicahGale MicahGale

Labels
bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". CI/CD documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MicahGale @coveralls @tjlaboss