Skip to content

Commit

Permalink
Further revisions and grammatical fixes (#21632)
Browse files Browse the repository at this point in the history
  • Loading branch information
CooperTrucks authored and GiudGiud committed Jan 3, 2023
1 parent 7fa4324 commit 2d7fbdd
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@

# Description

This boundary condition computes convective heat flux $q'' = H \cdot (T - T_{inf})$, where $H$ is convective heat transfer coefficient,
This boundary condition computes convective heat flux $q'' = h \cdot (T - T_{inf})$, where $H$ is convective heat transfer coefficient,
$T$ is the temperature, and $T_{inf}$ is far field temperature. Both $H$ and $T_{inf}$ are coupled as functors.
The domain can be specified as either a fluid or a solid using $is_solid$. For a solid domain, the equation above is applied.
The domain of the variable can be specified as either a fluid or a solid using $is\_solid$. For a solid domain, the equation above is applied.
For a fluid domain, the negative of the heat flux is applied. This allows for easier implementation of a double Robin
boundary condition.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
/**
* Robin boundary condition (temperatures) for finite volume scheme between
* a solid and fluid where the temperatures and heat transfer coefficient
* is given as a functor
* are given as a functors
*/
class FVFunctorConvectiveHeatFluxBC : public FVFluxBC
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#include "FVFunctorConvectiveHeatFluxBC.h"
#include "Function.h"

registerMooseObject("MooseApp", FVFunctorConvectiveHeatFluxBC);
registerMooseObject("HeatConductionApp", FVFunctorConvectiveHeatFluxBC);

InputParameters
FVFunctorConvectiveHeatFluxBC::validParams()
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[Tests]
[FVFunctorConvectiveHeatFlux]
[FVFunctorConvectiveHeatFluxBC]
issues = '#21632'
design = 'FVFunctorConvectiveHeatFlux.md'
design = 'FVFunctorConvectiveHeatFluxBC.md'
requirement = 'The system shall provide a convective heat flux boundary condition which uses functors as heat transfer coefficients and far-field temperature values'
type = Exodiff
input = fv_functor_convective_heat_flux.i
Expand Down
2 changes: 1 addition & 1 deletion modules/navier_stokes/src/fvbcs/FVFunctorNeumannBC.C
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#include "FVFunctorNeumannBC.h"
#include "Function.h"

registerMooseObject("MooseApp", FVFunctorNeumannBC);
registerMooseObject("NavierStokesApp", FVFunctorNeumannBC);

InputParameters
FVFunctorNeumannBC::validParams()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ velocity_interp_method='rc'
xmax = 5
ymin = -1
ymax = 1
nx = 50
ny = 16
nx = 25
ny = 8
[]
[]

Expand Down

0 comments on commit 2d7fbdd

Please sign in to comment.