Address comments, fix test (#24645)

idaholab · Jun 20, 2023 · 506b041 · 506b041
1 parent d173f3e
commit 506b041
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/framework/src/markers/BoundaryMarker.C b/framework/src/markers/BoundaryMarker.C
@@ -44,6 +44,7 @@ BoundaryMarker::computeElementMarker()
 {
   if (_distance == 0.0)
   {
+    // is the current element member of any selected boundary element set?
     for (const auto boundary : _boundary_ids)
       if (_mesh.isBoundaryElem(_current_elem->id(), boundary))
         return _mark;
@@ -58,6 +59,11 @@ BoundaryMarker::computeElementMarker()
       if (it != _bnd_elem_ids.end())
         for (const auto id : it->second)
         {
+          // shortcut if we are checing the current element itself
+          if (id == _current_elem->id())
+            return _mark;
+
+          // otherwise compute distance to the boundary elements
           const auto elem = _mesh.elemPtr(id);
           const auto r = _current_elem->vertex_average() - elem->vertex_average();
           if (r.norm() < _distance)

diff --git a/test/tests/userobjects/geometry_snap/tests b/test/tests/userobjects/geometry_snap/tests
@@ -12,7 +12,7 @@
   [block]
     type = 'Exodiff'
     input = 'block.i'
-    exodiff = 'block.e-s004'
+    exodiff = 'block_out.e-s004'
     issues = '#24645'
     requirement = "The system shall support 'snapping' or moving new nodes in lower dimensioanl "
                   "subdomains created by mesh adaptivity to the surface of a geometric sphere to "