Switch to regular functors for FVFunctorDirichletBC while we do not s…

…upport AD-Dirichlet fully refs #21374
idaholab · Jun 22, 2022 · 69ac1c1 · 69ac1c1
1 parent 1bd5fad
commit 69ac1c1
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 5 deletions.
diff --git a/framework/doc/content/source/fvbcs/FVFunctorDirichletBC.md b/framework/doc/content/source/fvbcs/FVFunctorDirichletBC.md
@@ -3,10 +3,16 @@
 ## Description
 
 `FVFunctorDirichletBC` will specify the value of a field at the boundary.
-The value will be determined by a `Functor`
+The value will be determined by a `Functor`.
+
+!alert note
+This boundary condition will only accept regular functors. ADFunctors (such as variables) must be
+converted to regular functors using a [FunctorADConverter.md].
 
 ## Example Syntax
 
+In this example the functor, a constant value of 10, is defined using a [GenericFunctorMaterial.md].
+
 !listing test/tests/fvbcs/fv_functor_dirichlet/fv_functor_dirichlet.i block=Materials
 
 !listing test/tests/fvbcs/fv_functor_dirichlet/fv_functor_dirichlet.i block=FVBCs

diff --git a/framework/include/fvbcs/FVFunctorDirichletBC.h b/framework/include/fvbcs/FVFunctorDirichletBC.h
@@ -22,5 +22,5 @@ class FVFunctorDirichletBC : public FVDirichletBCBase
 
 private:
   /// The value for this BC
-  const Moose::Functor<ADReal> & _functor;
+  const Moose::Functor<Real> & _functor;
 };
diff --git a/framework/src/fvbcs/FVFunctorDirichletBC.C b/framework/src/fvbcs/FVFunctorDirichletBC.C
@@ -22,12 +22,12 @@ FVFunctorDirichletBC::validParams()
 }
 
 FVFunctorDirichletBC::FVFunctorDirichletBC(const InputParameters & parameters)
-  : FVDirichletBCBase(parameters), _functor(getFunctor<ADReal>("functor"))
+  : FVDirichletBCBase(parameters), _functor(getFunctor<Real>("functor"))
 {
 }
 
 Real
 FVFunctorDirichletBC::boundaryValue(const FaceInfo & fi) const
 {
-  return MetaPhysicL::raw_value(_functor(singleSidedFaceArg(&fi)));
+  return _functor(singleSidedFaceArg(&fi));
 }
diff --git a/test/tests/fvbcs/fv_functor_dirichlet/fv_functor_dirichlet.i b/test/tests/fvbcs/fv_functor_dirichlet/fv_functor_dirichlet.i
@@ -38,7 +38,7 @@
 
 [Materials]
   [bc_value]
-    type = ADGenericFunctorMaterial
+    type = GenericFunctorMaterial
     prop_names = bc_value
     prop_values = 10
   []