Definition of destructor of materials class

[KamalnathOSU]

I have a special case where I have to declare a pointer to an external API in the constructor. I need to explicitly free the API pointer and I think I need to use the destructor class. (This is the continuation of discussion #24588)

Can you provide me a example of the destructor ?

Let's say, this is my GmTernary class.

#pragma once

#include "Material.h"
#include "DerivativeMaterialInterface.h"
#include <vector>

#include "pfm_sdk.h"

class GmTernary : public DerivativeMaterialInterface<Material>
{
public:
  static InputParameters validParams();
  GmTernary(const InputParameters & parameters);
  
protected:
  virtual void computeQpProperties();

private:
	PFM_SDK* _m_pfm_sdk;  
};

And this is my constructor

GmTernary::GmTernary(const InputParameters & parameters)
  : DerivativeMaterialInterface<Material>(parameters)
{
	_m_pfm_sdk = NULL;
        _m_pfm_sdk = Define_PFM_SDK( &m_args, calculate_parallel_tangent, msg_char); // Allocated _m_pfm_sdk pointer.
}

From the API libray, Delete_PFM_SDK( _m_pfm_sdk ) would appropriately free the pointer.
Where to appropriately call this API function ?

[GiudGiud]

Hello

You can call this API in the destructor of your new class. You ll want to make sure the default class destructor is mostly still called though.

You can do that by calling the base class destructor in your class destructor

Guillaume

[KamalnathOSU]

Hi, I tried the following definition for the destructor.

GmTernary::~GmTernary()
  {
	if(_m_pfm_sdk != NULL){
		cout<<"Deleting PFM_SDK pointer ..."<<endl;
		Delete_PFM_SDK( _m_pfm_sdk );
	}
	~DerivativeMaterialInterface<Material>();
  }

But I get the following compilation error

Checking if header needs updating: /home/kamalnath/projects/moose/framework/include/base/MooseRevision.h...
Creating Unity /home/kamalnath/projects/panmoose/build/unity_src/materials_Unity.C
Compiling C++ (in opt mode) /home/kamalnath/projects/panmoose/build/unity_src/materials_Unity.C...
   32 | #warning \
      |  ^~~~~~~
In file included from /home/kamalnath/projects/panmoose/build/unity_src/materials_Unity.C:2:
/home/kamalnath/projects/panmoose/src/materials/GmTernary.C: In destructor ‘virtual GmTernary::~GmTernary()’:
/home/kamalnath/projects/panmoose/src/materials/GmTernary.C:30:41: error: no matching function for call to ‘DerivativeMaterialInterface<Material>::DerivativeMaterialInterface()’
   30 |  ~DerivativeMaterialInterface<Material>();
      |                                         ^
In file included from /home/kamalnath/projects/panmoose/build/header_symlinks/GmTernary.h:5,
                 from /home/kamalnath/projects/panmoose/src/materials/GmTernary.C:1,
                 from /home/kamalnath/projects/panmoose/build/unity_src/materials_Unity.C:2:
/home/kamalnath/projects/moose/framework/build/header_symlinks/DerivativeMaterialInterface.h:198:1: note: candidate: ‘DerivativeMaterialInterface<T>::DerivativeMaterialInterface(const InputParameters&) [with T = Material]’
  198 | DerivativeMaterialInterface<T>::DerivativeMaterialInterface(const InputParameters & parameters)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/kamalnath/projects/moose/framework/build/header_symlinks/DerivativeMaterialInterface.h:198:1: note:   candidate expects 1 argument, 0 provided
/home/kamalnath/projects/moose/framework/build/header_symlinks/DerivativeMaterialInterface.h:32:7: note: candidate: ‘DerivativeMaterialInterface<Material>::DerivativeMaterialInterface(const DerivativeMaterialInterface<Material>&)’
   32 | class DerivativeMaterialInterface : public T, public DerivativeMaterialPropertyNameInterface
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/kamalnath/projects/moose/framework/build/header_symlinks/DerivativeMaterialInterface.h:32:7: note:   candidate expects 1 argument, 0 provided
/home/kamalnath/projects/moose/framework/build/header_symlinks/DerivativeMaterialInterface.h:32:7: note: candidate: ‘DerivativeMaterialInterface<Material>::DerivativeMaterialInterface(DerivativeMaterialInterface<Material>&&)’
/home/kamalnath/projects/moose/framework/build/header_symlinks/DerivativeMaterialInterface.h:32:7: note:   candidate expects 1 argument, 0 provided
make: *** [/home/kamalnath/projects/moose/framework/build.mk:149: /home/kamalnath/projects/panmoose/build/unity_src/materials_Unity.x86_64-pc-linux-gnu.opt.lo] Error 1

[GiudGiud]

nevermind you dont need to call the parent class destructor, that's done automatically
https://isocpp.org/wiki/faq/dtors#cant-overload-dtors

[lindsayad]

@KamalnathOSU please let us know if we can mark this as answered

[KamalnathOSU]

@lindsayad

Hi ! I was out of zone with MOOSE for sometime :)

Yes, it is answered. Thank you very much.