Do a better job of cleaning up the FileCache #11174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Job Documentation on a7ee7a9 wanted to post the following: View the site here This comment will be updated on new commits. |
brianmoose
force-pushed
the
fix-peacock
branch
2 times, most recently
from
74fe3aa
to
7cbafea
Compare
brianmoose
force-pushed
the
fix-peacock
branch
3 times, most recently
from
cca62e7
to
c8da52e
Compare
|
I ran this on a loop for a while with no failures. I also verified that the Qt settings and cache are empty after tests are run. |
permcody
approved these changes
Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to address the random peacock Mac failures, which I haven't been able to reproduce.
The basic assumption is that when the tests are run in parallel there is one or more tests messing with the same files, causing crashes/errors. Since tests run in their own directories, the main source of potential conflicts is the --json dump cache.
It does look like multiple tests were potentially writing to the same cache file since PeacockApp was overwriting the ApplicationName.
I also noticed that since we are clearing the QSettings at the start of a test, we were not properly cleaning up old cache files. There was ~300G of cache files on the mac test box and the partition was actually out of space. I suspect this also contributed to the random failures.
closes #11156