Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove similar code for command-line argument handling #13518

Open
aeslaughter opened this issue Jun 5, 2019 · 0 comments
Open

Remove similar code for command-line argument handling #13518

aeslaughter opened this issue Jun 5, 2019 · 0 comments
Labels
Good first issue P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@aeslaughter
Copy link
Contributor

Reason

The CommandLine::initForMultiApp method and the Parser::hitCLIFilter both have logic that is similar for separating MOOSE hit syntax from the supplied command-line arguments.

Design

These two methods should share a common code path or perhaps the use of one or the other can be removed. The reason for the current setup (see #13433) is to allow each MultiApp to have a unique CommandLine object.

Impact

The main goal is to remove duplicate logic, any impact should be internal and not influence operation.

@aeslaughter aeslaughter added T: task An enhancement to the software. P: normal A defect affecting operation with a low possibility of significantly affects. Good first issue labels Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Development

No branches or pull requests

1 participant