Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fluid_properties]: Add initial conditions for density computed from pressure and temperature #15524

Closed
andrsd opened this issue Jul 2, 2020 · 0 comments · Fixed by #15526
Closed

[fluid_properties]: Add initial conditions for density computed from pressure and temperature #15524

andrsd opened this issue Jul 2, 2020 · 0 comments · Fixed by #15526
Assignees
@andrsd
Labels
C: Modules P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@andrsd
Copy link
Contributor

andrsd commented Jul 2, 2020

Reason

We want all applications using the fluid property module to be able to set density using the module, so they do not have reimplement the same code over and over.

Design

This exists in THM and can be just moved into the module.

Impact

Less code duplication in client apps, lower maintenance burden.
@andrsd andrsd added T: task An enhancement to the software. P: normal A defect affecting operation with a low possibility of significantly affects. C: Modules labels Jul 2, 2020
@andrsd andrsd self-assigned this Jul 2, 2020
andrsd added a commit to andrsd/moose that referenced this issue Jul 2, 2020
@andrsd
Adding ICs to set density from pressure and temperature
26093ab 
Closes idaholab#15524
andrsd added a commit to andrsd/moose that referenced this issue Jul 2, 2020
@andrsd
Adding ICs to set density from pressure and temperature
a339eb0 
Closes idaholab#15524
@andrsd andrsd mentioned this issue Jul 2, 2020
Merged
andrsd added a commit to andrsd/moose that referenced this issue Jul 2, 2020
@andrsd
Adding ICs to set density from pressure and temperature
9f79a15 
Closes idaholab#15524
andrsd added a commit to andrsd/moose that referenced this issue Jul 6, 2020
@andrsd
Adding ICs to set density from pressure and temperature
c8076fe 
Closes idaholab#15524
milljm pushed a commit to milljm/moose that referenced this issue Jul 15, 2020
@andrsd @milljm
Adding ICs to set density from pressure and temperature
9746bda 
Closes idaholab#15524
moosebuild pushed a commit that referenced this issue Jan 30, 2022
@andrsd
Submodule update
f3b66a0 
Refs #15524
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrsd andrsd

Labels
C: Modules P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding ICs to set density from pressure and temperature andrsd/moose
1 participant
@andrsd