Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sub-app old time not properly updated with negative times and sub_cycling=false #15802

Closed
vincentlaboure opened this issue Sep 4, 2020 · 0 comments
Closed

Sub-app old time not properly updated with negative times and sub_cycling=false #15802

vincentlaboure opened this issue Sep 4, 2020 · 0 comments
Labels
C: Framework T: defect An anomaly, which is anything that deviates from expectations.

Comments

@vincentlaboure
Copy link
Contributor

Bug Description

Bug reported on the moose-users list.

Steps to Reproduce

Run a Transient MultiApp with sub_cycling=false and start at negative times. The sub-app time_old does not get updated until the main app gets to positive times.

Impact

This can cause the main and sub apps to get out of sync.
@vincentlaboure vincentlaboure added the T: defect An anomaly, which is anything that deviates from expectations. label Sep 4, 2020
vincentlaboure added a commit to vincentlaboure/moose that referenced this issue Sep 4, 2020
@vincentlaboure
Incrementing the time step of sub-apps should allow negative start ti…
248796f 
…mes idaholab#15802
vincentlaboure added a commit to vincentlaboure/moose that referenced this issue Sep 4, 2020
@vincentlaboure
Add test with negative time without sub-cycling. Close idaholab#15802
c739d1e
@vincentlaboure vincentlaboure mentioned this issue Sep 4, 2020
Merged
vincentlaboure added a commit to vincentlaboure/moose that referenced this issue Sep 28, 2020
@vincentlaboure
Add test with negative time without sub-cycling. Close idaholab#15802
6f11aad
vincentlaboure added a commit to vincentlaboure/moose that referenced this issue Sep 28, 2020
@vincentlaboure
Incrementing the time step of sub-apps should allow negative start ti…
42fdbc9 
…mes idaholab#15802
vincentlaboure added a commit to vincentlaboure/moose that referenced this issue Sep 28, 2020
@vincentlaboure
Add test with negative time without sub-cycling. Close idaholab#15802
24944bc
vincentlaboure added a commit to vincentlaboure/moose that referenced this issue Sep 28, 2020
@vincentlaboure
Incrementing the time step of sub-apps should allow negative start ti…
a7e92c3 
…mes idaholab#15802
vincentlaboure added a commit to vincentlaboure/moose that referenced this issue Sep 28, 2020
@vincentlaboure
Add test with negative time without sub-cycling. Close idaholab#15802
24a196b
vincentlaboure added a commit to vincentlaboure/moose that referenced this issue Sep 29, 2020
@vincentlaboure
Add test with negative time without sub-cycling. Close idaholab#15802
f70be78
vincentlaboure added a commit to vincentlaboure/moose that referenced this issue Oct 1, 2020
@vincentlaboure
The default time for an app should not be 0 (or problems with recover…
6233db0 
…ing as the start time is not explicitly set by the Transient executioner) idaholab#15802
vincentlaboure added a commit to vincentlaboure/moose that referenced this issue Oct 29, 2020
@vincentlaboure
Incrementing the time step of sub-apps should allow negative start ti…
5764238 
…mes idaholab#15802
vincentlaboure added a commit to vincentlaboure/moose that referenced this issue Oct 29, 2020
@vincentlaboure
Add test with negative time without sub-cycling. Close idaholab#15802
dee6031
vincentlaboure added a commit to vincentlaboure/moose that referenced this issue Oct 29, 2020
@vincentlaboure
The default time for an app should not be 0 (or problems with recover…
9daabde 
…ing as the start time is not explicitly set by the Transient executioner) idaholab#15802
vincentlaboure added a commit to vincentlaboure/moose that referenced this issue Oct 29, 2020
@vincentlaboure
Incrementing the time step of sub-apps should allow negative start ti…
efded00 
…mes idaholab#15802
vincentlaboure added a commit to vincentlaboure/moose that referenced this issue Oct 29, 2020
@vincentlaboure
The default time for an app should not be 0 (or problems with recover…
9c2a8f7 
…ing as the start time is not explicitly set by the Transient executioner) idaholab#15802
loganharbour pushed a commit to loganharbour/moose that referenced this issue Oct 31, 2020
@vincentlaboure @loganharbour
Incrementing the time step of sub-apps should allow negative start ti…
dbfc0e2 
…mes idaholab#15802
loganharbour pushed a commit to loganharbour/moose that referenced this issue Oct 31, 2020
@vincentlaboure @loganharbour
Add test with negative time without sub-cycling. Close idaholab#15802
5665efd
loganharbour pushed a commit to loganharbour/moose that referenced this issue Oct 31, 2020
@vincentlaboure @loganharbour
The default time for an app should not be 0 (or problems with recover…
cbf8274 
…ing as the start time is not explicitly set by the Transient executioner) idaholab#15802
jain651 pushed a commit to jain651/moose that referenced this issue Apr 19, 2021
@vincentlaboure
Incrementing the time step of sub-apps should allow negative start ti…
55489bf 
…mes idaholab#15802
jain651 pushed a commit to jain651/moose that referenced this issue Apr 19, 2021
@vincentlaboure
Add test with negative time without sub-cycling. Close idaholab#15802
76cfa67
jain651 pushed a commit to jain651/moose that referenced this issue Apr 19, 2021
@vincentlaboure
The default time for an app should not be 0 (or problems with recover…
4da2ed8 
…ing as the start time is not explicitly set by the Transient executioner) idaholab#15802
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Framework T: defect An anomaly, which is anything that deviates from expectations.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vincentlaboure @loganharbour