Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some ElementIDInterface functions need to be override in Material #16005

Closed
YaqiWang opened this issue Oct 26, 2020 · 0 comments · Fixed by #16006
Closed

Some ElementIDInterface functions need to be override in Material #16005

YaqiWang opened this issue Oct 26, 2020 · 0 comments · Fixed by #16006
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@YaqiWang
Copy link
Contributor

Reason

Material is different from DGKernel or InterfaceMaterial, where we can retrieve element IDs for both current and neighboring elements. Material owns three copies: element, face, neighbor. The first two should always get the current element ID while the last one gets the neighboring element ID. If we do not take care of this in Material, user materials much do the if (_neighbor) check when getting element IDs.

Design

A better design that can avoid potential bugs.

Impact

It can either fix potential bugs for applications or temporarily break applications.
@YaqiWang YaqiWang added P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software. labels Oct 26, 2020
YaqiWang added a commit to YaqiWang/moose that referenced this issue Oct 26, 2020
@YaqiWang
override functions in ElementIDInterface for materials idaholab#16005
da23907
YaqiWang added a commit to YaqiWang/moose that referenced this issue Oct 26, 2020
@YaqiWang
override functions in ElementIDInterface for materials idaholab#16005
ac380b9
@YaqiWang YaqiWang mentioned this issue Oct 26, 2020
Merged
YaqiWang added a commit to YaqiWang/moose that referenced this issue Oct 26, 2020
@YaqiWang
override functions in ElementIDInterface for materials idaholab#16005
e83f160
YaqiWang added a commit to YaqiWang/moose that referenced this issue Oct 26, 2020
@YaqiWang
override functions in ElementIDInterface for materials idaholab#16005
0235eaa
YaqiWang added a commit to YaqiWang/moose that referenced this issue Oct 27, 2020
@YaqiWang
override functions in ElementIDInterface for materials idaholab#16005
5696b01
YaqiWang added a commit to YaqiWang/moose that referenced this issue Oct 27, 2020
@YaqiWang
override functions in ElementIDInterface for materials idaholab#16005
f458c0f
jain651 pushed a commit to jain651/moose that referenced this issue Apr 19, 2021
@YaqiWang
override functions in ElementIDInterface for materials idaholab#16005
35d0d5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Element id interface for material YaqiWang/moose
2 participants
@YaqiWang @loganharbour