Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FV support for some postprocessors #16099

Open
GiudGiud opened this issue Nov 6, 2020 · 0 comments
Open

Add FV support for some postprocessors #16099

GiudGiud opened this issue Nov 6, 2020 · 0 comments
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@GiudGiud
Copy link
Contributor

GiudGiud commented Nov 6, 2020 •
edited

Reason

A few postprocessors and transfers use MooseVariable, which translate to a FE variable. This does not work for FV variables, as it finds a null for the variable pointer.

Design

MooseVariableFields may be used instead, a parent class which includes both FE and FV.

Impact

Enabling useful postprocessors and transfers for reactor modeling
@GiudGiud GiudGiud added P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software. labels Nov 6, 2020
GiudGiud added a commit to GiudGiud/moose that referenced this issue Nov 6, 2020
@GiudGiud
Set variable dependency using MooseVariableFIeld, adresses idaholab#1…
dce7b1a 
…6099
GiudGiud added a commit to GiudGiud/moose that referenced this issue Nov 8, 2020
@GiudGiud
Use field variables in two transfers, add postprocessor FV tests, efs i…
eacc0fe 
…daholab#16099
GiudGiud added a commit to GiudGiud/moose that referenced this issue Nov 8, 2020
@GiudGiud
Use MooseVariableField in PointSamplerBase, add test, fix some typos, i…
d7750c9 
…daholab#16099
GiudGiud added a commit to GiudGiud/moose that referenced this issue Nov 8, 2020
@GiudGiud
Add test for MultiAppVariableValueSampleTransfer for FV variables, id…
6ab54ad 
…aholab#16099
GiudGiud added a commit to GiudGiud/moose that referenced this issue Nov 9, 2020
@GiudGiud
Use MooseVariableFieldBase instead of MooseVariableField<Real>. Add t…
6e81f25 
…est for ElementVariableValuePP. idaholab#16099
@GiudGiud GiudGiud mentioned this issue Nov 9, 2020
Merged
GiudGiud added a commit to GiudGiud/moose that referenced this issue Nov 10, 2020
@GiudGiud
Add tests for FV user objects compatibility, ref idaholab#16099
6a3b037
GiudGiud added a commit to GiudGiud/moose that referenced this issue Nov 11, 2020
@GiudGiud
Skip new tests using FV with stateful materials, refs idaholab#16099 i…
6bc998e 
…daholab#16149
GiudGiud added a commit to GiudGiud/moose that referenced this issue Nov 12, 2020
@GiudGiud
Address @rwcarlsen review
8000835 
Use command line arguments to simplify interface value tests, idaholab#16099
GiudGiud added a commit to GiudGiud/moose that referenced this issue Nov 12, 2020
@GiudGiud
Address @rwcarlsen review
bcddbab 
Use command line arguments to simplify interface value tests, idaholab#16099
GiudGiud added a commit to GiudGiud/moose that referenced this issue Nov 12, 2020
@GiudGiud
Address @rwcarlsen review
21e9e5a 
Use command line arguments to simplify interface value tests, idaholab#16099
GiudGiud added a commit to GiudGiud/moose that referenced this issue Jan 20, 2021
@GiudGiud
Add advected quantity to VolumetricFlowRate postprocessor
5bc071f 
Add BoundaryVolumetricFlowRate for external boundaries
Refs idaholab#16099, would benefit from idaholab#16585
@GiudGiud GiudGiud mentioned this issue Jan 20, 2021
Merged
GiudGiud added a commit to GiudGiud/moose that referenced this issue Feb 3, 2021
@GiudGiud
Add advected quantity to VolumetricFlowRate postprocessor
3fbf60c 
Add BoundaryVolumetricFlowRate for external boundaries
Refs idaholab#16099, would benefit from idaholab#16585
GiudGiud added a commit to GiudGiud/moose that referenced this issue Feb 7, 2021
@GiudGiud
Use LU preconditioner to improve test repeatability, issue created by i…
a173af2 
…daholab#16767, refs idaholab#16099
@GiudGiud GiudGiud mentioned this issue Feb 7, 2021
Merged
GiudGiud added a commit to GiudGiud/moose that referenced this issue Feb 7, 2021
@GiudGiud
Use LU preconditioner to improve test repeatability, issue created by i…
932ba94 
…daholab#16767, refs idaholab#16099
GiudGiud added a commit to GiudGiud/moose that referenced this issue Feb 7, 2021
@GiudGiud
Use LU preconditioner to improve test repeatability, issue created by i…
ed86a6d 
…daholab#16767, refs idaholab#16099
jain651 pushed a commit to jain651/moose that referenced this issue Apr 19, 2021
@GiudGiud
Set variable dependency using MooseVariableFIeld, adresses idaholab#1…
65e5076 
…6099
jain651 pushed a commit to jain651/moose that referenced this issue Apr 19, 2021
@GiudGiud
Use field variables in two transfers, add postprocessor FV tests, efs i…
929d55d 
…daholab#16099
jain651 pushed a commit to jain651/moose that referenced this issue Apr 19, 2021
@GiudGiud
Use MooseVariableField in PointSamplerBase, add test, fix some typos, i…
ea83b5f 
…daholab#16099
jain651 pushed a commit to jain651/moose that referenced this issue Apr 19, 2021
@GiudGiud
Add test for MultiAppVariableValueSampleTransfer for FV variables, id…
caaa7e1 
…aholab#16099
jain651 pushed a commit to jain651/moose that referenced this issue Apr 19, 2021
@GiudGiud
Use MooseVariableFieldBase instead of MooseVariableField<Real>. Add t…
579eb93 
…est for ElementVariableValuePP. idaholab#16099
jain651 pushed a commit to jain651/moose that referenced this issue Apr 19, 2021
@GiudGiud
Add tests for FV user objects compatibility, ref idaholab#16099
9e4698a
jain651 pushed a commit to jain651/moose that referenced this issue Apr 19, 2021
@GiudGiud
Skip new tests using FV with stateful materials, refs idaholab#16099 i…
c0a7b97 
…daholab#16149
jain651 pushed a commit to jain651/moose that referenced this issue Apr 19, 2021
@GiudGiud
Address @rwcarlsen review
817a796 
Use command line arguments to simplify interface value tests, idaholab#16099
jain651 pushed a commit to jain651/moose that referenced this issue Apr 19, 2021
@GiudGiud
Add advected quantity to VolumetricFlowRate postprocessor
9b1ff19 
Add BoundaryVolumetricFlowRate for external boundaries
Refs idaholab#16099, would benefit from idaholab#16585
jain651 pushed a commit to jain651/moose that referenced this issue Apr 19, 2021
@GiudGiud
Use LU preconditioner to improve test repeatability, issue created by i…
4961d16 
…daholab#16767, refs idaholab#16099
aeslaughter pushed a commit to aeslaughter/moose that referenced this issue Jun 2, 2021
@GiudGiud @aeslaughter
Add advected quantity to VolumetricFlowRate postprocessor
88ba71e 
Add BoundaryVolumetricFlowRate for external boundaries
Refs idaholab#16099, would benefit from idaholab#16585
aeslaughter pushed a commit to aeslaughter/moose that referenced this issue Jun 2, 2021
@GiudGiud @aeslaughter
Use LU preconditioner to improve test repeatability, issue created by i…
f389599 
…daholab#16767, refs idaholab#16099
GiudGiud added a commit to GiudGiud/moose that referenced this issue Oct 27, 2022
@GiudGiud
Add side Qp support to SideIntegralFunctorPP
70aa6e0 
refs idaholab#16099
GiudGiud added a commit to GiudGiud/moose that referenced this issue Oct 27, 2022
@GiudGiud
Add element functor integral postprocessor, refs idaholab#16099
ac946c3
GiudGiud added a commit to GiudGiud/moose that referenced this issue Oct 27, 2022
@GiudGiud
Add sideQp test testing FE, FV variables, functions, functor matprop,…
d3cee0b 
… refs idaholab#16099
GiudGiud added a commit to GiudGiud/moose that referenced this issue Oct 27, 2022
@GiudGiud
Add element functor integral (with elemQp) test testing FE, FE higher…
4467cb9 
… order, FV variables, functions, functor matprop, refs idaholab#16099
GiudGiud added a commit to GiudGiud/moose that referenced this issue Oct 27, 2022
@GiudGiud
Add side Qp support to SideIntegralFunctorPP
f54747a 
refs idaholab#16099
GiudGiud added a commit to GiudGiud/moose that referenced this issue Oct 27, 2022
@GiudGiud
Add element functor integral postprocessor, refs idaholab#16099
b984a72
GiudGiud added a commit to GiudGiud/moose that referenced this issue Oct 27, 2022
@GiudGiud
Add sideQp test testing FE, FV variables, functions, functor matprop,…
b6fbacc 
… refs idaholab#16099
GiudGiud added a commit to GiudGiud/moose that referenced this issue Oct 27, 2022
@GiudGiud
Add element functor integral (with elemQp) test testing FE, FE higher…
d9d0931 
… order, FV variables, functions, functor matprop, refs idaholab#16099
@GiudGiud GiudGiud mentioned this issue Oct 27, 2022
Merged
GiudGiud added a commit to GiudGiud/moose that referenced this issue Oct 27, 2022
@GiudGiud
Add element functor integral (with elemQp) test testing FE, FE higher…
4055935 
… order, FV variables, functions, functor matprop, refs idaholab#16099
GiudGiud added a commit to GiudGiud/moose that referenced this issue Oct 28, 2022
@GiudGiud
Add side Qp support to SideIntegralFunctorPP
f22f676 
refs idaholab#16099
GiudGiud added a commit to GiudGiud/moose that referenced this issue Oct 28, 2022
@GiudGiud
Add element functor integral postprocessor, refs idaholab#16099
e561589
GiudGiud added a commit to GiudGiud/moose that referenced this issue Oct 28, 2022
@GiudGiud
Add sideQp test testing FE, FV variables, functions, functor matprop,…
f7a8934 
… refs idaholab#16099
GiudGiud added a commit to GiudGiud/moose that referenced this issue Oct 28, 2022
@GiudGiud
Add element functor integral (with elemQp) test testing FE, FE higher…
d6e983c 
… order, FV variables, functions, functor matprop, refs idaholab#16099
GiudGiud added a commit to GiudGiud/moose that referenced this issue Jan 14, 2023
@GiudGiud
Look at all potential candidates when sampling.
1d450d1 
This enables us to find the one actually owned by the local process when at a process boundary
refs idaholab#16099
GiudGiud added a commit to GiudGiud/moose that referenced this issue Jan 14, 2023
@GiudGiud
Look at all potential candidates when sampling.
2e9a779 
This enables us to find the one actually owned by the local process when at a process boundary
refs idaholab#16099
GiudGiud added a commit to GiudGiud/moose that referenced this issue Jan 14, 2023
@GiudGiud
Look at all potential candidates when sampling.
accc898 
This enables us to find the one actually owned by the local process when at a process boundary
refs idaholab#16099
maxnezdyur pushed a commit to maxnezdyur/moose that referenced this issue Feb 12, 2023
@GiudGiud @maxnezdyur
Add side Qp support to SideIntegralFunctorPP
c67358b 
refs idaholab#16099
maxnezdyur pushed a commit to maxnezdyur/moose that referenced this issue Feb 12, 2023
@GiudGiud @maxnezdyur
Add element functor integral postprocessor, refs idaholab#16099
3a5fec9
maxnezdyur pushed a commit to maxnezdyur/moose that referenced this issue Feb 12, 2023
@GiudGiud @maxnezdyur
Add sideQp test testing FE, FV variables, functions, functor matprop,…
e507279 
… refs idaholab#16099
maxnezdyur pushed a commit to maxnezdyur/moose that referenced this issue Feb 12, 2023
@GiudGiud @maxnezdyur
Add element functor integral (with elemQp) test testing FE, FE higher…
a8e3667 
… order, FV variables, functions, functor matprop, refs idaholab#16099
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aeslaughter @GiudGiud