Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow forcing N nonlinear iteration and add an absolute divergence tolerance #16474

Closed
arovinelli opened this issue Dec 12, 2020 · 1 comment · Fixed by #16475
Closed

Allow forcing N nonlinear iteration and add an absolute divergence tolerance #16474

arovinelli opened this issue Dec 12, 2020 · 1 comment · Fixed by #16475
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@arovinelli
Copy link
Contributor

arovinelli commented Dec 12, 2020

Reason

Sometimes is useful to allow for a few nonlinear iterations before checking for the divergence of the nonlinear solver via the usual tests (nl_divtol, nl_pinpong,...). Speaking with @fdkong this seems a feature most advanced users would like to have.

Also, the current implementation of divergence tolerance is the relative value with respect to the residual at nonlinear iteration 0:
fnorm > the_residual * divtol
Sometimes is useful to check against an absolute divergence tolerance

Design

add two input parameter to FEProbelmSolve: nl_forced_its, and abs_nl_divtol.
Modify FEProbelmBase::CheckNonlinearConvergence to account for the minimum number of required nonlinear iterations, and to check for the absolute divergence tolerance.

Impact

nothing as we default parameters will be set to not change MOOSE default behavior:
nl_forced_its default value will be 0
abs_nl_divtol default value will be 1e30

@arovinelli arovinelli added P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software. labels Dec 12, 2020
arovinelli pushed a commit to arovinelli/moose that referenced this issue Dec 12, 2020
@fdkong
Copy link
Contributor

fdkong commented Dec 12, 2020

Closes #15212

arovinelli pushed a commit to arovinelli/moose that referenced this issue Dec 17, 2020
jain651 pushed a commit to jain651/moose that referenced this issue Apr 19, 2021
GiudGiud added a commit to GiudGiud/moose that referenced this issue Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
3 participants