Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error messages when FVFluxBCs are not well placed #16882

Closed
GiudGiud opened this issue Feb 4, 2021 · 0 comments · Fixed by #16884
Closed

Error messages when FVFluxBCs are not well placed #16882

GiudGiud opened this issue Feb 4, 2021 · 0 comments · Fixed by #16884
Assignees
@GiudGiud
Labels
P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
FY 21 NEAMS TH Pronghorn

Comments

@GiudGiud
Copy link
Contributor

GiudGiud commented Feb 4, 2021

Reason

If you place FVFluxBCs in odd locations, like an internal sideset or a sideset that does not have the corresponding finite volume variable, you will be greated with "should not get here" ^^.

Design

Have distinct message for the two possibilities, and give enough information for the user to figure it out.

Impact

Catch some recent block restriction issues @smharper ran in
@GiudGiud GiudGiud added T: task An enhancement to the software. P: normal A defect affecting operation with a low possibility of significantly affects. C: Finite Volume labels Feb 4, 2021
@GiudGiud GiudGiud self-assigned this Feb 4, 2021
@GiudGiud GiudGiud added this to To do in FY 21 NEAMS TH Pronghorn via automation Feb 4, 2021
GiudGiud added a commit to GiudGiud/moose that referenced this issue Feb 4, 2021
@GiudGiud
Add test for FVFluxBCs possible issues refs idaholab#16882
c28191a
@GiudGiud GiudGiud mentioned this issue Feb 4, 2021
Merged
GiudGiud added a commit to GiudGiud/moose that referenced this issue Feb 4, 2021
@GiudGiud
Add information to FVFluxBC error on faces it should not be triggered on
6e6bf58 
Add test for FVFluxBCs possible issues
refs idaholab#16882
GiudGiud added a commit to GiudGiud/moose that referenced this issue Feb 4, 2021
@GiudGiud
Add information to FVFluxBC error on faces it should not be triggered on
b974049 
Add test for FVFluxBCs possible issues
refs idaholab#16882
GiudGiud added a commit to GiudGiud/moose that referenced this issue Feb 10, 2021
@GiudGiud
Add information to FVFluxBC error on faces it should not be triggered on
eabebef 
Add test for FVFluxBCs to capture this error
Add test for FVNeumannBC for regular use
refs idaholab#16882
FY 21 NEAMS TH Pronghorn automation moved this from To do to Done Feb 13, 2021
jain651 pushed a commit to jain651/moose that referenced this issue Apr 19, 2021
@GiudGiud
Add information to FVFluxBC error on faces it should not be triggered on
c37883b 
Add test for FVFluxBCs to capture this error
Add test for FVNeumannBC for regular use
refs idaholab#16882
aeslaughter pushed a commit to aeslaughter/moose that referenced this issue Jun 2, 2021
@GiudGiud @aeslaughter
Add information to FVFluxBC error on faces it should not be triggered on
0b08823 
Add test for FVFluxBCs to capture this error
Add test for FVNeumannBC for regular use
refs idaholab#16882
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GiudGiud GiudGiud

Labels
P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
FY 21 NEAMS TH Pronghorn
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add test for FVFluxBCs possible issues GiudGiud/moose
1 participant
@GiudGiud