Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework RenameBoundaryGenerator #16885

Closed
loganharbour opened this issue Feb 4, 2021 · 0 comments · Fixed by #16890
Closed

Rework RenameBoundaryGenerator #16885

loganharbour opened this issue Feb 4, 2021 · 0 comments · Fixed by #16890
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@loganharbour
Copy link
Member

Reason

RenameBoundaryGenerator is lacking a bit:

  • It is not independent of input ordering
  • It does not create temporaries when doing rename, which can result in merged boundaries
  • It does not have a single parameter name for new and old boundaries
  • And quite a bit more...

Design

Fix these things!

Impact

Better mesh generation.
@loganharbour loganharbour added C: Framework T: task An enhancement to the software. P: normal A defect affecting operation with a low possibility of significantly affects. labels Feb 4, 2021
loganharbour added a commit to loganharbour/moose that referenced this issue Feb 4, 2021
@loganharbour
Rework RenameBoundaryGenerator
1164dc2 
refs idaholab#16885
loganharbour added a commit to loganharbour/moose that referenced this issue Feb 4, 2021
@loganharbour
Rework RenameBoundaryGenerator
e60a1a3 
refs idaholab#16885
@loganharbour loganharbour mentioned this issue Feb 4, 2021
Merged
loganharbour added a commit to loganharbour/moose that referenced this issue Feb 4, 2021
@loganharbour
Use new parameters for RenameBoundaryGenerator
912abbe 
refs idaholab#16885
loganharbour added a commit to loganharbour/moose that referenced this issue Feb 5, 2021
@loganharbour
Rework RenameBoundaryGenerator
39aa6de 
refs idaholab#16885
loganharbour added a commit to loganharbour/moose that referenced this issue Feb 5, 2021
@loganharbour
Use new parameters for RenameBoundaryGenerator
4d0a103 
refs idaholab#16885
loganharbour added a commit to loganharbour/moose that referenced this issue Feb 5, 2021
@loganharbour
Rework RenameBoundaryGenerator
73b19b1 
refs idaholab#16885
loganharbour added a commit to loganharbour/moose that referenced this issue Feb 5, 2021
@loganharbour
Use new parameters for RenameBoundaryGenerator
61763a8 
refs idaholab#16885
loganharbour added a commit to loganharbour/moose that referenced this issue Feb 5, 2021
@loganharbour
Rework RenameBoundaryGenerator
7e5fb45 
refs idaholab#16885
loganharbour added a commit to loganharbour/moose that referenced this issue Feb 5, 2021
@loganharbour
Rework RenameBoundaryGenerator
5fadf15 
refs idaholab#16885
jain651 pushed a commit to jain651/moose that referenced this issue Apr 19, 2021
@loganharbour
Rework RenameBoundaryGenerator
47ab0f0 
refs idaholab#16885
aeslaughter pushed a commit to aeslaughter/moose that referenced this issue Jun 2, 2021
@loganharbour @aeslaughter
Rework RenameBoundaryGenerator
ab2d3b4 
refs idaholab#16885
@loganharbour loganharbour mentioned this issue May 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rework RenameBoundaryGenerator loganharbour/moose
1 participant
@loganharbour