Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff-able mesh side information is needed #16887

Closed
loganharbour opened this issue Feb 4, 2021 · 0 comments · Fixed by #16890
Closed

Diff-able mesh side information is needed #16887

loganharbour opened this issue Feb 4, 2021 · 0 comments · Fixed by #16890
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@loganharbour
Copy link
Member

Reason

Because exodiff does not check side IDs/names, it is difficult to test for the mesh side information.

Design

Add side information to MeshInfo so that we can use JSONDiff to diff for mesh side changes.

Impact

Better testing for mesh side information.
@loganharbour loganharbour added C: Framework T: task An enhancement to the software. P: normal A defect affecting operation with a low possibility of significantly affects. labels Feb 4, 2021
loganharbour added a commit to loganharbour/moose that referenced this issue Feb 4, 2021
@loganharbour
Add sideset information to MeshInfo
6f98f47 
refs idaholab#16887
loganharbour added a commit to loganharbour/moose that referenced this issue Feb 4, 2021
@loganharbour
Add sideset information to MeshInfo
e7141e8 
refs idaholab#16887
@loganharbour loganharbour mentioned this issue Feb 4, 2021
Merged
loganharbour added a commit to loganharbour/moose that referenced this issue Feb 5, 2021
@loganharbour
Add sideset information to MeshInfo
7162f89 
refs idaholab#16887
loganharbour added a commit to loganharbour/moose that referenced this issue Feb 5, 2021
@loganharbour
Add sideset information to MeshInfo
5a890b8 
refs idaholab#16887
loganharbour added a commit to loganharbour/moose that referenced this issue Feb 5, 2021
@loganharbour
Add sideset information to MeshInfo
b9b16b3 
refs idaholab#16887
jain651 pushed a commit to jain651/moose that referenced this issue Apr 19, 2021
@loganharbour
Add sideset information to MeshInfo
858609c 
refs idaholab#16887
aeslaughter pushed a commit to aeslaughter/moose that referenced this issue Jun 2, 2021
@loganharbour @aeslaughter
Add sideset information to MeshInfo
4b92f75 
refs idaholab#16887
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rework RenameBoundaryGenerator loganharbour/moose
1 participant
@loganharbour