Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simple parametric search capability using PID control #17271

Closed
GiudGiud opened this issue Mar 10, 2021 · 0 comments · Fixed by #17420
Closed

Add simple parametric search capability using PID control #17271

GiudGiud opened this issue Mar 10, 2021 · 0 comments · Fixed by #17420
Assignees
@GiudGiud
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
FY 21 NEAMS TH Pronghorn

Comments

@GiudGiud
Copy link
Contributor

GiudGiud commented Mar 10, 2021 •
edited

Reason

Be able to adjust pump power to make temperature delta match in a heated channel during a pseudo transient

Design

A simple PID controller would suffice, leveraging the control system.
Since this is for pseudo transients, I would leave the convergence check at the simulation level, instead of looking at how well the control is achieving the target

Impact

New capability in framework, though redundant with more specific optimization applications
Widely applicable for simple 1D parametric search
@GiudGiud GiudGiud added C: Framework T: task An enhancement to the software. P: normal A defect affecting operation with a low possibility of significantly affects. labels Mar 10, 2021
@GiudGiud GiudGiud self-assigned this Mar 10, 2021
@GiudGiud GiudGiud added this to To do in FY 21 NEAMS TH Pronghorn via automation Mar 10, 2021
GiudGiud added a commit to GiudGiud/moose that referenced this issue Mar 23, 2021
@GiudGiud
Add PID controller, refs idaholab#17271
da18c98
GiudGiud added a commit to GiudGiud/moose that referenced this issue Mar 23, 2021
@GiudGiud
Add PID controller, refs idaholab#17271
2d2fa37
@GiudGiud GiudGiud mentioned this issue Mar 23, 2021
Merged
GiudGiud added a commit to GiudGiud/moose that referenced this issue Mar 23, 2021
@GiudGiud
Add PID controller, refs idaholab#17271
2fd594c
GiudGiud added a commit to GiudGiud/moose that referenced this issue Apr 13, 2021
@GiudGiud
Add PID controller, refs idaholab#17271
651d029 
Update tests
Add resiliency to picard iteration fails
Add integral windup reset
GiudGiud added a commit to GiudGiud/moose that referenced this issue Apr 13, 2021
@GiudGiud
Add PID controller, refs idaholab#17271
0566a9c 
Update tests
Add resiliency to picard iteration fails
Add integral windup reset
GiudGiud added a commit to GiudGiud/moose that referenced this issue Apr 13, 2021
@GiudGiud
Add PID controller, refs idaholab#17271
2a7a322 
Update tests
Add resiliency to picard iteration fails
Add integral windup reset
GiudGiud added a commit to GiudGiud/moose that referenced this issue Apr 18, 2021
@GiudGiud
Add PID controller, refs idaholab#17271
e3b664e 
Update tests
Add resiliency to picard iteration fails
Add integral windup reset
FY 21 NEAMS TH Pronghorn automation moved this from To do to Done Apr 20, 2021
aeslaughter pushed a commit to aeslaughter/moose that referenced this issue Jun 2, 2021
@GiudGiud @aeslaughter
Add PID controller, refs idaholab#17271
0cc9e17 
Update tests
Add resiliency to picard iteration fails
Add integral windup reset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GiudGiud GiudGiud

Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
FY 21 NEAMS TH Pronghorn
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a PID controller for basic tuning / search / optimization GiudGiud/moose
1 participant
@GiudGiud