Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Reporter system does not support getting a value before it is declared #17468

Closed
aeslaughter opened this issue Mar 30, 2021 · 3 comments · Fixed by #17485
Closed

The Reporter system does not support getting a value before it is declared #17468

aeslaughter opened this issue Mar 30, 2021 · 3 comments · Fixed by #17485
Assignees
@zachmprince
Labels
C: Framework P: minor A defect that does not affect the accuracy of results. T: defect An anomaly, which is anything that deviates from expectations.

Comments

@aeslaughter
Copy link
Contributor

aeslaughter commented Mar 30, 2021 •
edited

Bug Description

If a ReporterValue is declared in initialSetup a reference cannot be defined in another objects constructor.

Steps to Reproduce

A test showing the problem will be added to this Issue.

see aeslaughter@321469c

Impact

Reduces the flexibility of the Reporter system.
@aeslaughter aeslaughter added the T: defect An anomaly, which is anything that deviates from expectations. label Mar 30, 2021
aeslaughter added a commit to aeslaughter/moose that referenced this issue Mar 31, 2021
@aeslaughter
Add test to get a reporter before it is declared
321469c 
(refs idaholab#17468)
@aeslaughter
Copy link
Contributor Author

@zachmprince Is the solution as simple as running the Reporter check after initialSetup is complete?

@zachmprince
Copy link
Contributor

@aeslaughter Yep, doing ReporterData::check() right after UserObject::initialSetup() worked.

zachmprince pushed a commit to zachmprince/moose that referenced this issue Apr 1, 2021
@aeslaughter @zachmprince
Add test to get a reporter before it is declared
5001345 
(refs idaholab#17468)
zachmprince added a commit to zachmprince/moose that referenced this issue Apr 1, 2021
@zachmprince
Making ReporterData check later idaholab#17468
674c107
zachmprince added a commit to zachmprince/moose that referenced this issue Apr 1, 2021
@zachmprince
Cloning reporters earlier in SamplerReporterTransfer idaholab#17468
ebcd082
zachmprince pushed a commit to zachmprince/moose that referenced this issue Apr 1, 2021
@aeslaughter @zachmprince
Add test to get a reporter before it is declared
dd68d30 
(refs idaholab#17468)
zachmprince added a commit to zachmprince/moose that referenced this issue Apr 1, 2021
@zachmprince
Making ReporterData check later idaholab#17468
0a265cb
zachmprince added a commit to zachmprince/moose that referenced this issue Apr 1, 2021
@zachmprince
Cloning reporters earlier in SamplerReporterTransfer idaholab#17468
3c48cfa
@zachmprince zachmprince mentioned this issue Apr 1, 2021
Merged
@aeslaughter aeslaughter added the P: minor A defect that does not affect the accuracy of results. label Apr 12, 2021
zachmprince pushed a commit to zachmprince/moose that referenced this issue Apr 16, 2021
@aeslaughter @zachmprince
Add test to get a reporter before it is declared
9b86453 
(refs idaholab#17468)
zachmprince added a commit to zachmprince/moose that referenced this issue Apr 16, 2021
@zachmprince
Making ReporterData check later idaholab#17468
a6a7e22
zachmprince added a commit to zachmprince/moose that referenced this issue Apr 16, 2021
@zachmprince
Cloning reporters earlier in SamplerReporterTransfer idaholab#17468
a2acf53
aeslaughter added a commit to aeslaughter/moose that referenced this issue Jun 2, 2021
@aeslaughter
Add test to get a reporter before it is declared
4d48163 
(refs idaholab#17468)
aeslaughter pushed a commit to aeslaughter/moose that referenced this issue Jun 2, 2021
@zachmprince @aeslaughter
Making ReporterData check later idaholab#17468
23a551e
aeslaughter pushed a commit to aeslaughter/moose that referenced this issue Jun 2, 2021
@zachmprince @aeslaughter
Cloning reporters earlier in SamplerReporterTransfer idaholab#17468
5a7f856
@lindsayad lindsayad mentioned this issue Dec 2, 2022
Merged
@lindsayad
Copy link
Member

lindsayad commented Dec 5, 2022 •
edited

So we have code in moose that declares reporter values in initialSetup?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zachmprince zachmprince

Labels
C: Framework P: minor A defect that does not affect the accuracy of results. T: defect An anomaly, which is anything that deviates from expectations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Creating intermediate class for STM trainers zachmprince/moose
4 participants
@aeslaughter @lindsayad @zachmprince @loganharbour