Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move FluidDensityAux from Pronghorn to fluid properties #17546

Closed
aprilnovak opened this issue Apr 8, 2021 · 0 comments · Fixed by #17547
Closed

Move FluidDensityAux from Pronghorn to fluid properties #17546

aprilnovak opened this issue Apr 8, 2021 · 0 comments · Fixed by #17547
Assignees
@aprilnovak
Labels
C: Modules P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@aprilnovak
Copy link
Contributor

Reason

Pronghorn has an auxkernel, FluidDensityAux, that computes density from a SinglePhaseFluidProperties user object as a function of pressure and temperature. I would like similar capabilities for Cardinal, so it makes sense to move this very general capability up into the fluid properties module.

Design

Move FluidDensityAux and its tests from Pronghorn to the fluid properties module.

Impact

Potentially name collisions with apps that have their own FluidDensityAux, or changes in parameter names depending on how people defined the pressure and temperature coupled variables.
@aprilnovak aprilnovak added P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software. labels Apr 8, 2021
aprilnovak added a commit to aprilnovak/moose that referenced this issue Apr 8, 2021
@aprilnovak
Move FluidDensityAux from Pronghorn to fluid property module. Refs id…
4f668b2 
…aholab#17546
@aprilnovak aprilnovak mentioned this issue Apr 8, 2021
Merged
aprilnovak added a commit to aprilnovak/moose that referenced this issue Apr 8, 2021
@aprilnovak
Move FluidDensityAux from Pronghorn to fluid property module. Refs id…
cce9205 
…aholab#17546
aprilnovak added a commit to aprilnovak/moose that referenced this issue Apr 19, 2021
@aprilnovak
Move FluidDensityAux from Pronghorn to fluid property module. Refs id…
e04ccfb 
…aholab#17546
aprilnovak added a commit to aprilnovak/moose that referenced this issue Apr 21, 2021
@aprilnovak
Move FluidDensityAux from Pronghorn to fluid property module. Refs id…
7b75322 
…aholab#17546
aeslaughter pushed a commit to aeslaughter/moose that referenced this issue Jun 11, 2021
@aprilnovak @aeslaughter
Move FluidDensityAux from Pronghorn to fluid property module. Refs id…
3033d89 
…aholab#17546
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aprilnovak aprilnovak

Labels
C: Modules P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move FluidDensityAux from Pronghorn to fluid property module. aprilnovak/moose
2 participants
@andrsd @aprilnovak