New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to test more about coupling variables with tagged solution vectors #17586

Closed

YaqiWang opened this issue Apr 12, 2021 · 0 comments · Fixed by #17589

Labels

P: normal T: task

Contributor

YaqiWang commented Apr 12, 2021

Reason

Coupling variables in a tagged solution vector can be very useful for designing custom iterative solve objects. It is not fully tested yet. And some of my preliminary investigations revealed some missing pieces of the dependency on initializing variables from a tagged solution vector.

Design

We need to add more tests and fix this loopholes for coupling variables with tagged solution vectors. I am planning to extend FixedPoint solve object in MOOSE test to test this capability and propose some fixes.

Impact

New capability.

The text was updated successfully, but these errors were encountered:

YaqiWang added P: normal T: task labels

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          add tag gradient idaholab#17586

1b99d11

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          break header dependency in material property interface idaholab#17586

8feda25

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          add missing pieces for coupling tagged solution vectors idaholab#17586

ff0e5dc

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          add more interface functions in Coupleable idaholab#17586

7dec1f7

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          fix constant monomial variable for coupling tagged solution vectors i…

62a2383

…daholab#17586

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          add tests for tagged coupling idaholab#17586

a5ad891

YaqiWang mentioned this issue

Fixes and tests for coupling tagged solution vectors #17589

Merged

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          more fixes in loops and variables idaholab#17586

16e1720

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          add missing pieces for coupling tagged solution vectors idaholab#17586

d8704bd

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          add more interface functions in Coupleable idaholab#17586

faef722

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          fix constant monomial variable for coupling tagged solution vectors i…

cec366a

…daholab#17586

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          add tests for tagged coupling idaholab#17586

c72c767

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          a fix for time integrator: associate vectors with tags early because …

a9bac02

…kernels may be using the tags idaholab#17586

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          break header dependency in material property interface idaholab#17586

ce42a77

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          add missing pieces for coupling tagged solution vectors idaholab#17586

3a46d63

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          add more interface functions in Coupleable idaholab#17586

f2f567c

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          fix constant monomial variable for coupling tagged solution vectors i…

5f517f3

…daholab#17586

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          add tests for tagged coupling idaholab#17586

b4cb9e2

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          a fix for time integrator: associate vectors with tags early because …

ab529c3

…kernels may be using the tags idaholab#17586

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          add missing pieces for coupling tagged solution vectors idaholab#17586

8b486a9

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          add more interface functions in Coupleable idaholab#17586

a62a67b

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          fix constant monomial variable for coupling tagged solution vectors i…

97533db

…daholab#17586

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          add tests for tagged coupling idaholab#17586

7ba5997

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          a fix for time integrator: associate vectors with tags early because …

272f751

…kernels may be using the tags idaholab#17586

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          add tag gradient idaholab#17586

8b36ba4

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          break header dependency in material property interface idaholab#17586

bf38632

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          add missing pieces for coupling tagged solution vectors idaholab#17586

ec74c2c

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          add tags for normal solution vectors (requires users to indicate solu…

3897f2b

…tion vector of previous Newton iteration is required or not) idaholab#17586

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          add more interface functions in Coupleable idaholab#17586

7f79c03

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          fix constant monomial variable for coupling tagged solution vectors i…

0c435b7

…daholab#17586

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          add tests for tagged coupling idaholab#17586

f465224

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          a fix for time integrator: associate vectors with tags early because …

dca0f8c

…kernels may be using the tags idaholab#17586

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          enable field transfers with tagged solution vector for idaholab#17586

7ebe675

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          support tagging the current solution idaholab#17586

YaqiWang added a commit to YaqiWang/moose that referenced this issue


          we need for now to shortcut a few calls in MooseVariableData for spec…

6f42c30

…ial tags otherwise end up with redundant evaluations idaholab#17586

fdkong closed this as completed in #17589

somu15 pushed a commit to somu15/moose that referenced this issue


          add tag gradient idaholab#17586

fe66b1f

somu15 pushed a commit to somu15/moose that referenced this issue


          break header dependency in material property interface idaholab#17586

a07d8ef

somu15 pushed a commit to somu15/moose that referenced this issue


          add missing pieces for coupling tagged solution vectors idaholab#17586

ebdcf9c

somu15 pushed a commit to somu15/moose that referenced this issue


          add tags for normal solution vectors (requires users to indicate solu…

855dde8

…tion vector of previous Newton iteration is required or not) idaholab#17586

somu15 pushed a commit to somu15/moose that referenced this issue


          add more interface functions in Coupleable idaholab#17586

f89a639

somu15 pushed a commit to somu15/moose that referenced this issue


          fix constant monomial variable for coupling tagged solution vectors i…

cc21acd

…daholab#17586

somu15 pushed a commit to somu15/moose that referenced this issue


          add tests for tagged coupling idaholab#17586

6d5dd08

somu15 pushed a commit to somu15/moose that referenced this issue


          a fix for time integrator: associate vectors with tags early because …

f8bd76e

…kernels may be using the tags idaholab#17586

somu15 pushed a commit to somu15/moose that referenced this issue


          enable field transfers with tagged solution vector for idaholab#17586

f6bf93e

somu15 pushed a commit to somu15/moose that referenced this issue


          support tagging the current solution idaholab#17586

70b7967

somu15 pushed a commit to somu15/moose that referenced this issue


          we need for now to shortcut a few calls in MooseVariableData for spec…

02c8b21

…ial tags otherwise end up with redundant evaluations idaholab#17586

aeslaughter pushed a commit to aeslaughter/moose that referenced this issue


          add tag gradient idaholab#17586

f6530c2

aeslaughter pushed a commit to aeslaughter/moose that referenced this issue


          break header dependency in material property interface idaholab#17586

bedf923

aeslaughter pushed a commit to aeslaughter/moose that referenced this issue


          add missing pieces for coupling tagged solution vectors idaholab#17586

5aa4cf4

aeslaughter pushed a commit to aeslaughter/moose that referenced this issue


          add tags for normal solution vectors (requires users to indicate solu…

8d51e30

…tion vector of previous Newton iteration is required or not) idaholab#17586

aeslaughter pushed a commit to aeslaughter/moose that referenced this issue


          add more interface functions in Coupleable idaholab#17586

72a51f7

aeslaughter pushed a commit to aeslaughter/moose that referenced this issue


          fix constant monomial variable for coupling tagged solution vectors i…

538b228

…daholab#17586

aeslaughter pushed a commit to aeslaughter/moose that referenced this issue


          add tests for tagged coupling idaholab#17586

9e361da

aeslaughter pushed a commit to aeslaughter/moose that referenced this issue


          a fix for time integrator: associate vectors with tags early because …

d6ea207

…kernels may be using the tags idaholab#17586

aeslaughter pushed a commit to aeslaughter/moose that referenced this issue


          enable field transfers with tagged solution vector for idaholab#17586

704ffa6

aeslaughter pushed a commit to aeslaughter/moose that referenced this issue


          support tagging the current solution idaholab#17586

d6b530e

aeslaughter pushed a commit to aeslaughter/moose that referenced this issue


          we need for now to shortcut a few calls in MooseVariableData for spec…

59f5921

…ial tags otherwise end up with redundant evaluations idaholab#17586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment