Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Reporter error handling, simplify get/declare #17605

Closed
loganharbour opened this issue Apr 14, 2021 · 0 comments · Fixed by #17527
Closed

Improve Reporter error handling, simplify get/declare #17605

loganharbour opened this issue Apr 14, 2021 · 0 comments · Fixed by #17527
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@loganharbour
Copy link
Member

Reason

The Reporter system could benefit from a variety of enhancements.

Design

  • Declare Reporter values for Postprocessors and VectorPostprocessors in the objects themselves, removing the need for things like SetupPostprocessorDataAction
  • Store producer and consumer MooseObjects in the ReporterState itself so that we can report better errors when things weren't produced, or things were requested/declared with the same name and same type
  • Keep track of the state when a Reporter is actually declared a Postprocessor or VectorPostprocessor, both for output and error handling
  • Add checking on type when declaring/requesting Reporters

Impact

Will enhance public APIs and add more usable errors. Should not effect the use of the system.
@loganharbour loganharbour added C: Framework T: task An enhancement to the software. P: normal A defect affecting operation with a low possibility of significantly affects. labels Apr 14, 2021
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 14, 2021
@loganharbour
Reporter system enhancements
bd072e7 
- Declare Reporter values for PPs and VPPs within the objects themselves
- Add type checking on declare/request for Reporters with the same name
- Add producer/consumer MooseObject ptrs in ReporterState
- Add getter for information about a Reporter (type, producers, consumers,
  context, modes)
- Add more error handling to ReporterData, Reporter, and ReporterInterface

refs idaholab#17512 idaholab#17605
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 14, 2021
@loganharbour
Add more tests for Reporter and ReporterInterface
686a234 
refs idaholab#17512 idaholab#17605
@loganharbour loganharbour mentioned this issue Apr 14, 2021
Merged
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 14, 2021
@loganharbour
Add object for outputting Reporter debug information
3bbc7d7 
refs idaholab#17605
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 14, 2021
@loganharbour
Reporter system enhancements
bd81dc6 
- Declare Reporter values for PPs and VPPs within the objects themselves
- Add type checking on declare/request for Reporters with the same name
- Add producer/consumer MooseObject ptrs in ReporterState
- Add getter for information about a Reporter (type, producers, consumers,
  context, modes)
- Add more error handling to ReporterData, Reporter, and ReporterInterface

refs idaholab#17512 idaholab#17605
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 14, 2021
@loganharbour
Add more tests for Reporter and ReporterInterface
6ae4a67 
refs idaholab#17512 idaholab#17605
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 14, 2021
@loganharbour
Add object for outputting Reporter debug information
1480820 
refs idaholab#17605
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 17, 2021
@loganharbour
Reporter system enhancements
367d0f8 
- Declare Reporter values for PPs and VPPs within the objects themselves
- Add type checking on declare/request for Reporters with the same name
- Add producer/consumer MooseObject ptrs in ReporterState
- Add getter for information about a Reporter (type, producers, consumers,
  context, modes)
- Add more error handling to ReporterData, Reporter, and ReporterInterface

refs idaholab#17512 idaholab#17605
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 17, 2021
@loganharbour
Add more tests for Reporter and ReporterInterface
c6fd08a 
refs idaholab#17512 idaholab#17605
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 17, 2021
@loganharbour
Add object for outputting Reporter debug information
899609a 
refs idaholab#17605
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 17, 2021
@loganharbour
Add test design/doco pages for Reporter and VPP interfaces
7ef4f44 
refs idaholab#17605 idaholab#17512
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 18, 2021
@loganharbour
Move over-zealous assertion
2c4ec73 
refs idaholab#17605
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 18, 2021
@loganharbour
Clean up PP interface for default values and remove deprecated methods
72e7f8f 
refs idaholab#17512 idaholab#17605
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 19, 2021
@loganharbour
Reporter system enhancements
0240ee5 
- Declare Reporter values for PPs and VPPs within the objects themselves
- Add type checking on declare/request for Reporters with the same name
- Add producer/consumer MooseObject ptrs in ReporterState
- Add getter for information about a Reporter (type, producers, consumers,
  context, modes)
- Add more error handling to ReporterData, Reporter, and ReporterInterface

refs idaholab#17512 idaholab#17605
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 19, 2021
@loganharbour
Add more tests for Reporter and ReporterInterface
f9562df 
refs idaholab#17512 idaholab#17605
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 19, 2021
@loganharbour
Add object for outputting Reporter debug information
9f86249 
refs idaholab#17605
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 19, 2021
@loganharbour
Add test design/doco pages for Reporter and VPP interfaces
214277e 
refs idaholab#17605 idaholab#17512
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 19, 2021
@loganharbour
Move over-zealous assertion
73b5c75 
refs idaholab#17605
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 19, 2021
@loganharbour
Clean up PP interface for default values and remove deprecated methods
75e9c50 
refs idaholab#17512 idaholab#17605
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 19, 2021
@loganharbour
Clean up PP interface for default values and remove deprecated methods
0fe9f60 
refs idaholab#17512 idaholab#17605
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 21, 2021
@loganharbour
Reporter system enhancements
8093aa8 
- Declare Reporter values for PPs and VPPs within the objects themselves
- Add type checking on declare/request for Reporters with the same name
- Add producer/consumer MooseObject ptrs in ReporterState
- Add getter for information about a Reporter (type, producers, consumers,
  context, modes)
- Add more error handling to ReporterData, Reporter, and ReporterInterface

refs idaholab#17512 idaholab#17605
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 21, 2021
@loganharbour
Add more tests for Reporter and ReporterInterface
6501aa6 
refs idaholab#17512 idaholab#17605
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 21, 2021
@loganharbour
Add object for outputting Reporter debug information
6f264c2 
refs idaholab#17605
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 21, 2021
@loganharbour
Add test design/doco pages for Reporter and VPP interfaces
291eb9f 
refs idaholab#17605 idaholab#17512
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 21, 2021
@loganharbour
Move over-zealous assertion
d14e5d1 
refs idaholab#17605
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 21, 2021
@loganharbour
Clean up PP interface for default values and remove deprecated methods
dfd94d6 
refs idaholab#17512 idaholab#17605
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 21, 2021
@loganharbour
Move Reporter producer ownership to the context
931d472 
refs idaholab#17605
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 21, 2021
@loganharbour
Move Reporter producer ownership to the context
882d868 
refs idaholab#17605
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 21, 2021
@loganharbour
Move Reporter producer ownership to the context
4cec036 
refs idaholab#17605
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 21, 2021
@loganharbour
Move Reporter producer ownership to the context
4abe124 
refs idaholab#17605
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 21, 2021
@loganharbour
Move Reporter producer ownership to the context
3fc26b1 
refs idaholab#17605
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 27, 2021
@loganharbour
Reporter system enhancements
047bf32 
- Declare Reporter values for PPs and VPPs within the objects themselves
- Add type checking on declare/request for Reporters with the same name
- Add producer/consumer MooseObject ptrs in ReporterState
- Add getter for information about a Reporter (type, producers, consumers,
  context, modes)
- Add more error handling to ReporterData, Reporter, and ReporterInterface

refs idaholab#17512 idaholab#17605
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 27, 2021
@loganharbour
Add more tests for Reporter and ReporterInterface
79ed14d 
refs idaholab#17512 idaholab#17605
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 27, 2021
@loganharbour
Add object for outputting Reporter debug information
9ae750e 
refs idaholab#17605
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 27, 2021
@loganharbour
Add test design/doco pages for Reporter and VPP interfaces
a9891ee 
refs idaholab#17605 idaholab#17512
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 27, 2021
@loganharbour
Move over-zealous assertion
0490c0d 
refs idaholab#17605
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 27, 2021
@loganharbour
Clean up PP interface for default values and remove deprecated methods
13ec1cb 
refs idaholab#17512 idaholab#17605
loganharbour added a commit to loganharbour/moose that referenced this issue Apr 27, 2021
@loganharbour
Move Reporter producer ownership to the context
8919c90 
refs idaholab#17605
somu15 pushed a commit to somu15/moose that referenced this issue May 15, 2021
@loganharbour @somu15
Reporter system enhancements
57cc599 
- Declare Reporter values for PPs and VPPs within the objects themselves
- Add type checking on declare/request for Reporters with the same name
- Add producer/consumer MooseObject ptrs in ReporterState
- Add getter for information about a Reporter (type, producers, consumers,
  context, modes)
- Add more error handling to ReporterData, Reporter, and ReporterInterface

refs idaholab#17512 idaholab#17605
somu15 pushed a commit to somu15/moose that referenced this issue May 15, 2021
@loganharbour @somu15
Add more tests for Reporter and ReporterInterface
fbf04b5 
refs idaholab#17512 idaholab#17605
somu15 pushed a commit to somu15/moose that referenced this issue May 15, 2021
@loganharbour @somu15
Add object for outputting Reporter debug information
35c1be1 
refs idaholab#17605
somu15 pushed a commit to somu15/moose that referenced this issue May 15, 2021
@loganharbour @somu15
Add test design/doco pages for Reporter and VPP interfaces
acd0504 
refs idaholab#17605 idaholab#17512
somu15 pushed a commit to somu15/moose that referenced this issue May 15, 2021
@loganharbour @somu15
Move over-zealous assertion
c173ff2 
refs idaholab#17605
somu15 pushed a commit to somu15/moose that referenced this issue May 15, 2021
@loganharbour @somu15
Clean up PP interface for default values and remove deprecated methods
e52d04b 
refs idaholab#17512 idaholab#17605
somu15 pushed a commit to somu15/moose that referenced this issue May 15, 2021
@loganharbour @somu15
Move Reporter producer ownership to the context
eb175b3 
refs idaholab#17605
aeslaughter pushed a commit to aeslaughter/moose that referenced this issue Jun 2, 2021
@loganharbour @aeslaughter
Reporter system enhancements
dc411b5 
- Declare Reporter values for PPs and VPPs within the objects themselves
- Add type checking on declare/request for Reporters with the same name
- Add producer/consumer MooseObject ptrs in ReporterState
- Add getter for information about a Reporter (type, producers, consumers,
  context, modes)
- Add more error handling to ReporterData, Reporter, and ReporterInterface

refs idaholab#17512 idaholab#17605
aeslaughter pushed a commit to aeslaughter/moose that referenced this issue Jun 2, 2021
@loganharbour @aeslaughter
Add more tests for Reporter and ReporterInterface
ebf35b0 
refs idaholab#17512 idaholab#17605
aeslaughter pushed a commit to aeslaughter/moose that referenced this issue Jun 2, 2021
@loganharbour @aeslaughter
Add object for outputting Reporter debug information
34287f5 
refs idaholab#17605
aeslaughter pushed a commit to aeslaughter/moose that referenced this issue Jun 2, 2021
@loganharbour @aeslaughter
Add test design/doco pages for Reporter and VPP interfaces
498da8a 
refs idaholab#17605 idaholab#17512
aeslaughter pushed a commit to aeslaughter/moose that referenced this issue Jun 2, 2021
@loganharbour @aeslaughter
Move over-zealous assertion
ad8fa31 
refs idaholab#17605
aeslaughter pushed a commit to aeslaughter/moose that referenced this issue Jun 2, 2021
@loganharbour @aeslaughter
Clean up PP interface for default values and remove deprecated methods
d9ed02f 
refs idaholab#17512 idaholab#17605
aeslaughter pushed a commit to aeslaughter/moose that referenced this issue Jun 2, 2021
@loganharbour @aeslaughter
Move Reporter producer ownership to the context
1c0e795 
refs idaholab#17605
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Various (many...) interface and Reporter enhancements loganharbour/moose
1 participant
@loganharbour