Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PostprocessorInterface to initial conditions #17692

Closed
joshuahansel opened this issue Apr 27, 2021 · 0 comments · Fixed by #17694
Closed

Add PostprocessorInterface to initial conditions #17692

joshuahansel opened this issue Apr 27, 2021 · 0 comments · Fixed by #17694
Labels
T: task An enhancement to the software.

Comments

@joshuahansel
Copy link
Contributor

Reason

Sometimes initial conditions depend on post-processor values. One example is this: a user provides a distribution function, but it needs to be normalized first, which requires an integral of that function, and thus ElementIntegralPostprocessor can be used for this.

Design

This would have InitialConditionBase inherit from PostprocessorInterface.

Impact

This allows initial conditions to inherit the APIs provided by PostprocessorInterface.
@joshuahansel joshuahansel added the T: task An enhancement to the software. label Apr 27, 2021
joshuahansel added a commit to joshuahansel/moose that referenced this issue Apr 27, 2021
@joshuahansel
Added PostprocessorInterface to InitialConditionBase
1287925 
- Added PostprocessorInterface to InitialConditionBase
- Added overloads for InitialConditionBase::getPostprocessorValue
  and InitialConditionBase::getPostprocessorValueByName that add
  the post-processor name to the user object dependency list
- Tested correct dependency resolution of both new overloads
- Added news entry

Closes idaholab#17692
@joshuahansel joshuahansel mentioned this issue Apr 27, 2021
Merged
joshuahansel added a commit to joshuahansel/moose that referenced this issue Apr 28, 2021
@joshuahansel
Added PostprocessorInterface to InitialConditionBase
7478c55 
- Added PostprocessorInterface to InitialConditionBase
- Added overloads for InitialConditionBase::getPostprocessorValue
  and InitialConditionBase::getPostprocessorValueByName that add
  the post-processor name to the user object dependency list
- Tested correct dependency resolution of both new overloads
- Added news entry

Closes idaholab#17692
somu15 pushed a commit to somu15/moose that referenced this issue May 15, 2021
@joshuahansel @somu15
Added PostprocessorInterface to InitialConditionBase
c8aec39 
- Added PostprocessorInterface to InitialConditionBase
- Added overloads for InitialConditionBase::getPostprocessorValue
  and InitialConditionBase::getPostprocessorValueByName that add
  the post-processor name to the user object dependency list
- Tested correct dependency resolution of both new overloads
- Added news entry

Closes idaholab#17692
aeslaughter pushed a commit to aeslaughter/moose that referenced this issue Jun 2, 2021
@joshuahansel @aeslaughter
Added PostprocessorInterface to InitialConditionBase
4b9934f 
- Added PostprocessorInterface to InitialConditionBase
- Added overloads for InitialConditionBase::getPostprocessorValue
  and InitialConditionBase::getPostprocessorValueByName that add
  the post-processor name to the user object dependency list
- Tested correct dependency resolution of both new overloads
- Added news entry

Closes idaholab#17692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added PostprocessorInterface to InitialConditionBase joshuahansel/moose
1 participant
@joshuahansel