Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add second time derivative support for AD variables #18178

Closed
cticenhour opened this issue Jun 25, 2021 · 0 comments · Fixed by #18179
Closed

Add second time derivative support for AD variables #18178

cticenhour opened this issue Jun 25, 2021 · 0 comments · Fixed by #18179
Assignees
@cticenhour
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@cticenhour
Copy link
Member

Reason

For AD objects that require second time derivatives, an adUDotDot option doesn't exist. This should be added.

Design

Add adUDotDot and adUDotDotNeighbor in MooseVariable* classes, and implement in the Newmark-Beta and Central Difference time integrators. Add an adCoupledDotDot method for developers to use in custom object param definitions.

Impact

New capability.
@cticenhour cticenhour added C: Framework T: task An enhancement to the software. P: normal A defect affecting operation with a low possibility of significantly affects. labels Jun 25, 2021
@cticenhour cticenhour self-assigned this Jun 25, 2021
cticenhour added a commit to cticenhour/moose that referenced this issue Jun 25, 2021
@cticenhour
Implement ad_u_dot_dot (idaholab#18178)
62c1452
cticenhour pushed a commit to cticenhour/moose that referenced this issue Jun 25, 2021
@lindsayad @cticenhour
Switch to using references (idaholab#18178)
3a53468
cticenhour added a commit to cticenhour/moose that referenced this issue Jun 25, 2021
@cticenhour
Add AD second time derivative getters (idaholab#18178)
aaba568
cticenhour added a commit to cticenhour/moose that referenced this issue Jun 25, 2021
@cticenhour
Partially revert change to newmark-beta helper method (idaholab#18178)
3aa8304
cticenhour added a commit to cticenhour/moose that referenced this issue Jun 25, 2021
@cticenhour
Add adCoupledDotDot method (idaholab#18178)
837f5ad
cticenhour added a commit to cticenhour/moose that referenced this issue Jun 25, 2021
@cticenhour
Add tests for newmark beta and central difference (idaholab#18178)
69d56a2
@cticenhour cticenhour mentioned this issue Jun 25, 2021
Merged
cticenhour added a commit to cticenhour/moose that referenced this issue Jun 25, 2021
@cticenhour
clang format (idaholab#18178)
f7e5185
cticenhour added a commit to cticenhour/moose that referenced this issue Jul 8, 2021
@cticenhour
Implement ad_u_dot_dot (idaholab#18178)
9ef076d
cticenhour pushed a commit to cticenhour/moose that referenced this issue Jul 8, 2021
@lindsayad @cticenhour
Switch to using references (idaholab#18178)
bc1a472
cticenhour added a commit to cticenhour/moose that referenced this issue Jul 8, 2021
@cticenhour
Add AD second time derivative getters (idaholab#18178)
3c3c293
cticenhour added a commit to cticenhour/moose that referenced this issue Jul 8, 2021
@cticenhour
Partially revert change to newmark-beta helper method (idaholab#18178)
422ca86
cticenhour added a commit to cticenhour/moose that referenced this issue Jul 8, 2021
@cticenhour
Add adCoupledDotDot method (idaholab#18178)
f0dd311
cticenhour added a commit to cticenhour/moose that referenced this issue Jul 8, 2021
@cticenhour
Add tests for newmark beta and central difference (idaholab#18178)
fa7291b
cticenhour added a commit to cticenhour/moose that referenced this issue Jul 8, 2021
@cticenhour
clang format (idaholab#18178)
2262556
cticenhour added a commit to cticenhour/moose that referenced this issue Jul 8, 2021
@cticenhour
Implement adUDotDot in MooseVariableDataFV (idaholab#18178)
8dd0501
cticenhour added a commit to cticenhour/moose that referenced this issue Jul 13, 2021
@cticenhour
Address more review comments (idaholab#18178)
2fdf84b 
- Removes errant requirement number from new ad newmark test. 
- Moved method definitions for adUDot and adUDotDot to outside class 
definition (still in header).
cticenhour added a commit to cticenhour/moose that referenced this issue Jul 13, 2021
@cticenhour
Address more review comments (idaholab#18178)
6eee15b 
- Removes errant requirement number from new ad newmark and central 
difference tests. 
- Moved method definitions for adUDot and adUDotDot to outside class 
definition (still in header).
cticenhour added a commit to cticenhour/moose that referenced this issue Jul 13, 2021
@cticenhour
Add finite volume AD dotdot test (idaholab#18178)
3690605
cticenhour added a commit to cticenhour/moose that referenced this issue Jul 13, 2021
@cticenhour
Fix typo in fv_dotdot test spec (idaholab#18178)
1cbd222
cticenhour added a commit to cticenhour/moose that referenced this issue Jul 14, 2021
@cticenhour
Implement ad_u_dot_dot (idaholab#18178)
50020fa
cticenhour pushed a commit to cticenhour/moose that referenced this issue Jul 14, 2021
@lindsayad @cticenhour
Switch to using references (idaholab#18178)
65e05f0
cticenhour added a commit to cticenhour/moose that referenced this issue Jul 14, 2021
@cticenhour
Add AD second time derivative getters (idaholab#18178)
2378d06
cticenhour added a commit to cticenhour/moose that referenced this issue Jul 14, 2021
@cticenhour
Partially revert change to newmark-beta helper method (idaholab#18178)
988de1b
cticenhour added a commit to cticenhour/moose that referenced this issue Jul 14, 2021
@cticenhour
Add adCoupledDotDot method (idaholab#18178)
224e460
cticenhour added a commit to cticenhour/moose that referenced this issue Jul 14, 2021
@cticenhour
Add tests for newmark beta and central difference (idaholab#18178)
22ade83
cticenhour added a commit to cticenhour/moose that referenced this issue Jul 14, 2021
@cticenhour
clang format (idaholab#18178)
8b93c5f
cticenhour added a commit to cticenhour/moose that referenced this issue Jul 14, 2021
@cticenhour
Implement adUDotDot in MooseVariableDataFV (idaholab#18178)
4ee58d6
cticenhour added a commit to cticenhour/moose that referenced this issue Jul 14, 2021
@cticenhour
Address more review comments (idaholab#18178)
e1fd113 
- Removes errant requirement number from new ad newmark and central 
difference tests. 
- Moved method definitions for adUDot and adUDotDot to outside class 
definition (still in header).
cticenhour added a commit to cticenhour/moose that referenced this issue Jul 14, 2021
@cticenhour
Add finite volume AD dotdot test (idaholab#18178)
8373ee6
cticenhour added a commit to cticenhour/moose that referenced this issue Jul 14, 2021
@cticenhour
Fix typo in fv_dotdot test spec (idaholab#18178)
738dd9a
cticenhour added a commit to cticenhour/moose that referenced this issue Jul 14, 2021
@cticenhour
Add finite volume AD dotdot test (idaholab#18178)
fc62c0a
cticenhour added a commit to cticenhour/moose that referenced this issue Jul 15, 2021
@cticenhour
Implement ad_u_dot_dot (idaholab#18178)
022785d
cticenhour pushed a commit to cticenhour/moose that referenced this issue Jul 15, 2021
@lindsayad @cticenhour
Switch to using references (idaholab#18178)
e190d6a
cticenhour added a commit to cticenhour/moose that referenced this issue Jul 15, 2021
@cticenhour
Add AD second time derivative getters (idaholab#18178)
67afa9d
cticenhour added a commit to cticenhour/moose that referenced this issue Jul 15, 2021
@cticenhour
Partially revert change to newmark-beta helper method (idaholab#18178)
528628e
cticenhour added a commit to cticenhour/moose that referenced this issue Jul 15, 2021
@cticenhour
Add adCoupledDotDot method (idaholab#18178)
ee2e258
cticenhour added a commit to cticenhour/moose that referenced this issue Jul 15, 2021
@cticenhour
Add tests for newmark beta and central difference (idaholab#18178)
195fa98
cticenhour added a commit to cticenhour/moose that referenced this issue Jul 15, 2021
@cticenhour
clang format (idaholab#18178)
bd050fa
cticenhour added a commit to cticenhour/moose that referenced this issue Jul 15, 2021
@cticenhour
Implement adUDotDot in MooseVariableDataFV (idaholab#18178)
e51498a
cticenhour added a commit to cticenhour/moose that referenced this issue Jul 15, 2021
@cticenhour
Address more review comments (idaholab#18178)
f3dd8c5 
- Removes errant requirement number from new ad newmark and central 
difference tests. 
- Moved method definitions for adUDot and adUDotDot to outside class 
definition (still in header).
cticenhour added a commit to cticenhour/moose that referenced this issue Jul 15, 2021
@cticenhour
Add finite volume AD dotdot test (idaholab#18178)
b85b531
jbadger95 pushed a commit to jbadger95/moose that referenced this issue Aug 9, 2021
@cticenhour @jbadger95
Implement ad_u_dot_dot (idaholab#18178)
ecc82f0
jbadger95 pushed a commit to jbadger95/moose that referenced this issue Aug 9, 2021
@lindsayad @jbadger95
Switch to using references (idaholab#18178)
64c5026
jbadger95 pushed a commit to jbadger95/moose that referenced this issue Aug 9, 2021
@cticenhour @jbadger95
Add AD second time derivative getters (idaholab#18178)
a0623b2
jbadger95 pushed a commit to jbadger95/moose that referenced this issue Aug 9, 2021
@cticenhour @jbadger95
Partially revert change to newmark-beta helper method (idaholab#18178)
d4dfbd7
jbadger95 pushed a commit to jbadger95/moose that referenced this issue Aug 9, 2021
@cticenhour @jbadger95
Add adCoupledDotDot method (idaholab#18178)
289fc83
jbadger95 pushed a commit to jbadger95/moose that referenced this issue Aug 9, 2021
@cticenhour @jbadger95
Add tests for newmark beta and central difference (idaholab#18178)
fdc65c1
jbadger95 pushed a commit to jbadger95/moose that referenced this issue Aug 9, 2021
@cticenhour @jbadger95
clang format (idaholab#18178)
a938508
jbadger95 pushed a commit to jbadger95/moose that referenced this issue Aug 9, 2021
@cticenhour @jbadger95
Implement adUDotDot in MooseVariableDataFV (idaholab#18178)
1f170aa
jbadger95 pushed a commit to jbadger95/moose that referenced this issue Aug 9, 2021
@cticenhour @jbadger95
Address more review comments (idaholab#18178)
0e9fce4 
- Removes errant requirement number from new ad newmark and central 
difference tests. 
- Moved method definitions for adUDot and adUDotDot to outside class 
definition (still in header).
jbadger95 pushed a commit to jbadger95/moose that referenced this issue Aug 9, 2021
@cticenhour @jbadger95
Add finite volume AD dotdot test (idaholab#18178)
67edfe4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cticenhour cticenhour

Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add adUDotDot and infrastructure cticenhour/moose
1 participant
@cticenhour