Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code conditionally compiled for PETSc <3.5 #19195

Closed
dschwen opened this issue Oct 25, 2021 · 0 comments · Fixed by #19197
Closed

Remove code conditionally compiled for PETSc <3.5 #19195

dschwen opened this issue Oct 25, 2021 · 0 comments · Fixed by #19197
Assignees
@dschwen
Labels
T: task An enhancement to the software.

Comments

@dschwen
Copy link
Member

dschwen commented Oct 25, 2021

Reason

Libmesh removed support for old PETSc versions pre 3.5 in February'21. so there is no point keeping this code around in MOOSE and MOSOE-based apps.

Design

Hunt down ifdefs and remove conditionally compiled code supporting PETSc < 3.5

Impact

Cleanup
@dschwen dschwen added the T: task An enhancement to the software. label Oct 25, 2021
@dschwen dschwen self-assigned this Oct 25, 2021
dschwen added a commit to dschwen/moose that referenced this issue Oct 25, 2021
@dschwen
Remove support for PETSc < 3.5 (idaholab#19195)
8dc8a56
@dschwen dschwen mentioned this issue Oct 25, 2021
Merged
dschwen added a commit to dschwen/moose that referenced this issue Oct 25, 2021
@dschwen
Address comments (idaholab#19195)
9280e3d
dschwen added a commit to dschwen/moose that referenced this issue Oct 25, 2021
@dschwen
Remove 3.5 test (idaholab#19195)
50cf97b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dschwen dschwen

Labels
T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove support for PETSc < 3.5 dschwen/moose
1 participant
@dschwen