Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sibling (MultiApp to MultiApp) Transfers #19451

Closed
GiudGiud opened this issue Nov 22, 2021 · 7 comments · Fixed by #17417
Closed

Sibling (MultiApp to MultiApp) Transfers #19451

GiudGiud opened this issue Nov 22, 2021 · 7 comments · Fixed by #17417
Labels
C: Framework T: task An enhancement to the software.
Projects
FY22 NEAMS MP - User Oriented Enhance...

Comments

@GiudGiud
Copy link
Contributor

GiudGiud commented Nov 22, 2021 •
edited

Reason

Allowing for multiapp to multiapp direct transfers avoids having a variable on the mesh in the main app to temporarily store the result.

Design

Think it through in every transfer since we d want that to be a general capability

Need a to_multiapp and from_multiapp

PRs:
#19676
#17417

Impact

Shorter input files with multiapps
-1/3 of the memory cost currently used for those operations
@GiudGiud GiudGiud added C: Framework T: task An enhancement to the software. labels Nov 22, 2021
@GiudGiud GiudGiud added this to To do in FY22 NEAMS MP - User Oriented Enhancements via automation Nov 22, 2021
@friedmud
Copy link
Contributor

AKA sibling or peer transfers (for searchability)

@friedmud
Copy link
Contributor

Design note: should be entirely initiated and housed in the master app (i.e. the siblings still shouldn't know that it is happening)

GiudGiud added a commit to GiudGiud/moose that referenced this issue Dec 22, 2021
@GiudGiud
Add between multiapp transfer
5117850 
Refs idaholab#19451
GiudGiud added a commit to GiudGiud/moose that referenced this issue Dec 22, 2021
@GiudGiud
Add between multiapp transfer
fea6cac 
Refs idaholab#19451
@friedmud friedmud changed the title Subapp to subapp direct transfers Sibling (MultiApp to MultiApp) Transfers Jan 25, 2022
GiudGiud added a commit to GiudGiud/moose that referenced this issue Feb 11, 2022
@GiudGiud
Add between multiapp transfer
afb0cbd 
Refs idaholab#19451
GiudGiud added a commit to GiudGiud/moose that referenced this issue Feb 18, 2022
@GiudGiud
Add between multiapp transfer
5eb5c61 
Refs idaholab#19451
GiudGiud added a commit to GiudGiud/moose that referenced this issue Feb 19, 2022
@GiudGiud
Update modules' transfers
75c040d 
Refs idaholab#19451
GiudGiud added a commit to GiudGiud/moose that referenced this issue Feb 19, 2022
@GiudGiud
Update modules' transfers
65aec0c 
Refs idaholab#19451
GiudGiud added a commit to GiudGiud/moose that referenced this issue Feb 23, 2022
@GiudGiud
Update modules' transfers
6713238 
Improve robustness of between_multiapp transfers

Refs idaholab#19451
GiudGiud added a commit to GiudGiud/moose that referenced this issue Feb 23, 2022
@GiudGiud
Add support for multiapp postprocessor transfer between multiapps, refs
0093001 
idaholab#19451
GiudGiud added a commit to GiudGiud/moose that referenced this issue Feb 23, 2022
@GiudGiud
Add support for multiapp postprocessor to scalar auxvariables transfe…
6b80e4a 
…r between multiapps, refs idaholab#19451
GiudGiud added a commit to GiudGiud/moose that referenced this issue Feb 23, 2022
@GiudGiud
Add support for multiapp scalar variable to scalar auxvariables trans…
70bc8e6 
…fer between multiapps, refs idaholab#19451
GiudGiud added a commit to GiudGiud/moose that referenced this issue Feb 23, 2022
@GiudGiud
Only transfer from one subapp to another with the same index, not to …
a58fc7d 
…all subapps (in between_multiapp mode), refs idaholab#19451
GiudGiud added a commit to GiudGiud/moose that referenced this issue Feb 23, 2022
@GiudGiud
Add support for reporter transfer between multiapps, refs idaholab#19451
1697f4c
GiudGiud added a commit to GiudGiud/moose that referenced this issue Feb 23, 2022
@GiudGiud
Adapt framework tests to new syntax, refs idaholab#19451
41d8c20
GiudGiud added a commit to GiudGiud/moose that referenced this issue Feb 23, 2022
@GiudGiud
Adapt modules test to new syntax, refs idaholab#19451
2b92d3a
GiudGiud added a commit to GiudGiud/moose that referenced this issue Feb 23, 2022
@GiudGiud
Add support for reporter transfer between multiapps, refs idaholab#19451
968eeb7 


Make variable checking more robust for parallel simulations
GiudGiud added a commit to GiudGiud/moose that referenced this issue Feb 23, 2022
@GiudGiud
Add support for reporter transfer between multiapps, refs idaholab#19451
d1283c1 


Make variable checking more robust for parallel simulations
Clang
GiudGiud added a commit to GiudGiud/moose that referenced this issue Feb 23, 2022
@GiudGiud
Adapt framework tests to new syntax, refs idaholab#19451
e86e763
GiudGiud added a commit to GiudGiud/moose that referenced this issue Feb 23, 2022
@GiudGiud
Adapt modules test to new syntax, refs idaholab#19451
0befac9
GiudGiud added a commit to GiudGiud/moose that referenced this issue Feb 23, 2022
@GiudGiud
Fix parameter spelling, refs idaholab#19451
0a5f3ae
GiudGiud added a commit to GiudGiud/moose that referenced this issue Feb 23, 2022
@GiudGiud
Add more deprecated parameter support to MultiAppCloneReporterTransfe…
e08c2e6 
…r, refs idaholab#19451
GiudGiud added a commit to idaholab/mastodon that referenced this issue Feb 24, 2022
@GiudGiud
Adapt transfers for compatibility with moose sibling multiapp transfe…
2f9cb12 
…rs, refs idaholab/moose#19451
GiudGiud added a commit to idaholab/mastodon that referenced this issue Feb 24, 2022
@GiudGiud
Adapt all input files to new syntax, refs idaholab/moose#19451
b27a02b
GiudGiud added a commit to GiudGiud/moose that referenced this issue Feb 24, 2022
@GiudGiud
Dont need to get both problems on first pass of getAppInfo for bi-dir…
94669ac 
…ectional transfer, refs idaholab#19451
GiudGiud added a commit to GiudGiud/moose that referenced this issue Feb 24, 2022
@GiudGiud
Add between multiapp transfer
52479df 
Refs idaholab#19451
MengnanLi91 pushed a commit to MengnanLi91/moose that referenced this issue Jan 4, 2023
@GiudGiud @MengnanLi91
Adapt to new API for retrieving multiapp (idaholab#19451)
7d2f578
zachmprince added a commit to zachmprince/moose that referenced this issue Jan 18, 2023
@zachmprince
Avoiding error with deprecated transfer input idaholab#19451
65f07bd
@lindsayad
Copy link
Member

exciting stuff!

zachmprince added a commit to zachmprince/moose that referenced this issue Feb 16, 2023
@zachmprince
Avoiding error with deprecated transfer input idaholab#19451
394b0bd
MengnanLi91 pushed a commit to MengnanLi91/moose that referenced this issue Feb 22, 2023
@zachmprince @MengnanLi91
Avoiding error with deprecated transfer input idaholab#19451
8027ab3
MengnanLi91 pushed a commit to MengnanLi91/moose that referenced this issue Feb 23, 2023
@zachmprince @MengnanLi91
Avoiding error with deprecated transfer input idaholab#19451
fca7f3b
MengnanLi91 pushed a commit to MengnanLi91/moose that referenced this issue Mar 8, 2023
@zachmprince @MengnanLi91
Avoiding error with deprecated transfer input idaholab#19451
82fecba
GiudGiud added a commit to GiudGiud/moose that referenced this issue Mar 27, 2023
@GiudGiud
Remove zealous asserts banning transfer of variable 0, refs idaholab#…
1f3c2d7 
…19451
@GiudGiud GiudGiud mentioned this issue Mar 27, 2023
Merged
GiudGiud added a commit to GiudGiud/moose that referenced this issue Mar 27, 2023
@GiudGiud
Remove zealous asserts banning transfer of variable 0, refs idaholab#…
44de910 
…19451
GiudGiud added a commit to GiudGiud/moose that referenced this issue Jan 31, 2024
@GiudGiud
Allow general field transfers to do siblings
9aa6ce3 
refs idaholab#19451
GiudGiud added a commit to GiudGiud/moose that referenced this issue Jan 31, 2024
@GiudGiud
Allow PP transfer to do 1-N or N-N siblings transfer
7b71a17 
refs idaholab#19451
GiudGiud added a commit to GiudGiud/moose that referenced this issue Jan 31, 2024
@GiudGiud
Add testing for general field siblings transfers
8cbbffd 
refs idaholab#19451
GiudGiud added a commit to GiudGiud/moose that referenced this issue Jan 31, 2024
@GiudGiud
Document and add check on copy transfer doing N-N siblings transfer, …
91b937a 
…refs idaholab#19451
GiudGiud added a commit to GiudGiud/moose that referenced this issue Jan 31, 2024
@GiudGiud
Document and add check on reporter transfer doing N-N siblings transf…
a5cdf3d 
…er, refs idaholab#19451
GiudGiud added a commit to GiudGiud/moose that referenced this issue Jan 31, 2024
@GiudGiud
Document and add check on PP to aux-scalar transfer doing N-N sibling…
5eb2244 
…s transfer, refs idaholab#19451
GiudGiud added a commit to GiudGiud/moose that referenced this issue Jan 31, 2024
@GiudGiud
Document and add check on scalar var to aux-scalar transfer doing N-N…
8406579 
… siblings transfer, refs idaholab#19451
GiudGiud added a commit to GiudGiud/moose that referenced this issue Jan 31, 2024
@GiudGiud
Add testing for general field siblings transfers
2b7e349 
refs idaholab#19451
GiudGiud added a commit to GiudGiud/moose that referenced this issue Jan 31, 2024
@GiudGiud
Document and add check on copy transfer doing N-N siblings transfer, …
2bc5909 
…refs idaholab#19451
GiudGiud added a commit to GiudGiud/moose that referenced this issue Jan 31, 2024
@GiudGiud
Document and add check on reporter transfer doing N-N siblings transf…
b031ecf 
…er, refs idaholab#19451
GiudGiud added a commit to GiudGiud/moose that referenced this issue Jan 31, 2024
@GiudGiud
Document and add check on PP to aux-scalar transfer doing N-N sibling…
90c61d1 
…s transfer, refs idaholab#19451
GiudGiud added a commit to GiudGiud/moose that referenced this issue Jan 31, 2024
@GiudGiud
Document and add check on scalar var to aux-scalar transfer doing N-N…
9c38973 
… siblings transfer, refs idaholab#19451
schakrabortygithub pushed a commit to schakrabortygithub/moose that referenced this issue Mar 12, 2024
@GiudGiud @subhendu-LANL
Allow general field transfers to do siblings
1ee12cc 
refs idaholab#19451
schakrabortygithub pushed a commit to schakrabortygithub/moose that referenced this issue Mar 12, 2024
@GiudGiud @subhendu-LANL
Allow PP transfer to do 1-N or N-N siblings transfer
d5c231f 
refs idaholab#19451
schakrabortygithub pushed a commit to schakrabortygithub/moose that referenced this issue Mar 12, 2024
@GiudGiud @subhendu-LANL
Add testing for general field siblings transfers
d473482 
refs idaholab#19451
schakrabortygithub pushed a commit to schakrabortygithub/moose that referenced this issue Mar 12, 2024
@GiudGiud @subhendu-LANL
Document and add check on copy transfer doing N-N siblings transfer, …
b438c46 
…refs idaholab#19451
schakrabortygithub pushed a commit to schakrabortygithub/moose that referenced this issue Mar 12, 2024
@GiudGiud @subhendu-LANL
Document and add check on reporter transfer doing N-N siblings transf…
6311970 
…er, refs idaholab#19451
schakrabortygithub pushed a commit to schakrabortygithub/moose that referenced this issue Mar 12, 2024
@GiudGiud @subhendu-LANL
Document and add check on PP to aux-scalar transfer doing N-N sibling…
659bb6b 
…s transfer, refs idaholab#19451
schakrabortygithub pushed a commit to schakrabortygithub/moose that referenced this issue Mar 12, 2024
@GiudGiud @subhendu-LANL
Document and add check on scalar var to aux-scalar transfer doing N-N…
d6189ca 
… siblings transfer, refs idaholab#19451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Framework T: task An enhancement to the software.
Projects
No open projects
FY22 NEAMS MP - User Oriented Enhance...
To do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

General multiapp field transfer fdkong/moose
4 participants
@friedmud @lindsayad @fdkong @GiudGiud