Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow TabulatedFluidProperties to be used with (v,e) & (v,h) arguments #20101

Closed
snschune opened this issue Jan 21, 2022 · 4 comments
Closed

Allow TabulatedFluidProperties to be used with (v,e) & (v,h) arguments #20101

snschune opened this issue Jan 21, 2022 · 4 comments
Labels
C: Modules/Fluid Properties Tickets pertaining to the fluid_properties module T: task An enhancement to the software.

Comments

@snschune
Copy link
Contributor

Reason

TabulatedFluidProperties is a flexible class to provide custom fluid properties.
However, it does not work with THM because it only implements (p, T) lookups.

Design

Implement a reverse interpolation p(v,e), T(v,e), p(v,h),T(v,h) and then reuse
(p,T) implementation.

Impact

new capability
@snschune snschune added the T: task An enhancement to the software. label Jan 21, 2022
snschune pushed a commit to snschune/moose that referenced this issue Jan 21, 2022
Does AD work (idaholab#20101)
62eca27
@snschune snschune mentioned this issue Jan 21, 2022
Closed
snschune pushed a commit to snschune/moose that referenced this issue Jan 21, 2022
Implement AD interfaces (idaholab#20101)
194f5c7
snschune pushed a commit to snschune/moose that referenced this issue Jan 21, 2022
Implement AD interfaces (idaholab#20101)
3feaf10
@loganharbour loganharbour added C: Modules/Fluid Properties Tickets pertaining to the fluid_properties module P: normal A defect affecting operation with a low possibility of significantly affects. P: high and removed P: normal A defect affecting operation with a low possibility of significantly affects. P: high labels Jan 22, 2022
snschune pushed a commit to snschune/moose that referenced this issue Feb 17, 2022
Implement a calorically imperfect gas (idaholab#20101)
cb42113
snschune pushed a commit to snschune/moose that referenced this issue Feb 17, 2022
Implement a calorically imperfect gas (idaholab#20101)
d137cbc
snschune pushed a commit to snschune/moose that referenced this issue Feb 17, 2022
Implement a calorically imperfect gas (idaholab#20101)
2f628be
snschune pushed a commit to snschune/moose that referenced this issue Feb 23, 2022
Address comments (idaholab#20101)
c6fcb88
snschune pushed a commit to snschune/moose that referenced this issue Feb 23, 2022
Address comments (idaholab#20101)
4bf1fcc
snschune pushed a commit to snschune/moose that referenced this issue Feb 23, 2022
Add documentation (idaholab#20101)
5df2384
snschune pushed a commit to snschune/moose that referenced this issue Feb 24, 2022
Add more consistency testing (idaholab#20101)
db795a5
snschune pushed a commit to snschune/moose that referenced this issue Feb 27, 2022
Reimplement the entropy functions depending on pt, hp, ve, Tv (idahol…
94be6be 
…ab#20101)
snschune pushed a commit to snschune/moose that referenced this issue Feb 27, 2022
Document how entropy is computed (idaholab#20101)
a4d55aa
snschune pushed a commit to snschune/moose that referenced this issue Feb 27, 2022
Add Gibbs free energy calculation and regression test (idaholab#20101)
05202f5
snschune pushed a commit to snschune/moose that referenced this issue Feb 28, 2022
Add Gibbs free energy calculation and regression test (idaholab#20101)
c322816
snschune pushed a commit to snschune/moose that referenced this issue Feb 28, 2022
Fix errors in documentation (idaholab#20101)
acaa6ba
joshuahansel pushed a commit to joshuahansel/moose that referenced this issue Mar 1, 2022
@joshuahansel
Implement a calorically imperfect gas (idaholab#20101)
e509c6b
joshuahansel pushed a commit to joshuahansel/moose that referenced this issue Mar 1, 2022
@joshuahansel
Address comments (idaholab#20101)
728ab18
joshuahansel pushed a commit to joshuahansel/moose that referenced this issue Mar 1, 2022
@joshuahansel
Add documentation (idaholab#20101)
f8fe3fc
joshuahansel pushed a commit to joshuahansel/moose that referenced this issue Mar 1, 2022
@joshuahansel
Add more consistency testing (idaholab#20101)
4d0004b
joshuahansel pushed a commit to joshuahansel/moose that referenced this issue Mar 1, 2022
@joshuahansel
Reimplement the entropy functions depending on pt, hp, ve, Tv (idahol…
5e86456 
…ab#20101)
joshuahansel pushed a commit to joshuahansel/moose that referenced this issue Mar 1, 2022
@joshuahansel
Document how entropy is computed (idaholab#20101)
e59ca74
joshuahansel pushed a commit to joshuahansel/moose that referenced this issue Mar 1, 2022
@joshuahansel
Add Gibbs free energy calculation and regression test (idaholab#20101)
27300ed
joshuahansel pushed a commit to joshuahansel/moose that referenced this issue Mar 1, 2022
@joshuahansel
Fix errors in documentation (idaholab#20101)
754e94d
GiudGiud added a commit to licharlot/moose that referenced this issue Sep 16, 2022
@GiudGiud
Add documentation to the fluid properties materials, refs idaholab#20101
6212c61
GiudGiud added a commit to licharlot/moose that referenced this issue Sep 16, 2022
@GiudGiud
Improve docstrings for TFP
6b96c0e 
Improve parameter descriptions for TFP
Dont check initial guesses if you re not using conversions between variable sets
Remove debug output
Fix error message for vh conversions
refs idaholab#20101
GiudGiud added a commit to licharlot/moose that referenced this issue Sep 16, 2022
@GiudGiud
Regold ve tabulation due to change from Brent to Newton method for va…
69e03ec 
…riable set inversion, refs idaholab#20101
GiudGiud added a commit to licharlot/moose that referenced this issue Sep 16, 2022
@GiudGiud
Remove deprecated libmesh routine in bicubic interpolation, refs idah…
b33f6f7 
…olab#20101
GiudGiud added a commit to licharlot/moose that referenced this issue Sep 16, 2022
@GiudGiud
Add more unit tests to increase framework coverage of bi-dimensional …
9402007 
…interpolations, refs idaholab#20101
GiudGiud added a commit to licharlot/moose that referenced this issue Sep 16, 2022
@GiudGiud
Add test for fluid properties materials, refs idaholab#20101
1db90e8
GiudGiud added a commit to licharlot/moose that referenced this issue Sep 16, 2022
@GiudGiud
Apply review from Josh
0414a0b 
- add Newton util documentation and change namespace
- remove unused routine
- fix up TFP documentation
Refs idaholab#20101
GiudGiud added a commit to licharlot/moose that referenced this issue Sep 16, 2022
@GiudGiud
Buff TFP documentation, explain pitfalls of inversions between variba…
17acbb1 
…le sets

add Bicubic TFP documentation page
Clean up Newton inversion routines
Add max iteration parameter
refs idaholab#20101
GiudGiud added a commit to licharlot/moose that referenced this issue Sep 16, 2022
@GiudGiud
Add more exception checking, refs idaholab#20101
81fa1e7
GiudGiud added a commit to licharlot/moose that referenced this issue Sep 16, 2022
@GiudGiud
Address Josh's review:
abdcbba 
- move FPMat PH to a test object
- remove unecessary AD TFP routines which were stolent from SFP anyway
- remove name() from error calls as it s output anyway
- clean up TFP_ve test
- move util page out of syntax
Refs idaholab#20101
GiudGiud added a commit to licharlot/moose that referenced this issue Sep 16, 2022
@GiudGiud
Address Josh's review
71db1bd 
- simplify tabulated ve test
- fix units in fluid properties material
- improve formatting of TFP documentation
- dont refer to base class name in context of input files

Add SFP documentation page. It is rather reduced as the main index.md page is mostly SFP material
refs idaholab#20101
GiudGiud added a commit to licharlot/moose that referenced this issue Sep 16, 2022
@GiudGiud
Regold ve tabulation due to change from Brent to Newton method for va…
098f313 
…riable set inversion, refs idaholab#20101
GiudGiud added a commit to licharlot/moose that referenced this issue Sep 16, 2022
@GiudGiud
Remove deprecated libmesh routine in bicubic interpolation, refs idah…
c32220c 
…olab#20101
GiudGiud added a commit to licharlot/moose that referenced this issue Sep 16, 2022
@GiudGiud
Add more unit tests to increase framework coverage of bi-dimensional …
4aa952c 
…interpolations, refs idaholab#20101
GiudGiud added a commit to licharlot/moose that referenced this issue Sep 16, 2022
@GiudGiud
Add test for fluid properties materials, refs idaholab#20101
d9d276e
GiudGiud added a commit to licharlot/moose that referenced this issue Sep 16, 2022
@GiudGiud
Apply review from Josh
1985fde 
- add Newton util documentation and change namespace
- remove unused routine
- fix up TFP documentation
Refs idaholab#20101
GiudGiud added a commit to licharlot/moose that referenced this issue Sep 16, 2022
@GiudGiud
Buff TFP documentation, explain pitfalls of inversions between variba…
ab36c0e 
…le sets

add Bicubic TFP documentation page
Clean up Newton inversion routines
Add max iteration parameter
refs idaholab#20101
GiudGiud added a commit to licharlot/moose that referenced this issue Sep 16, 2022
@GiudGiud
Add more exception checking, refs idaholab#20101
775a848
GiudGiud added a commit to licharlot/moose that referenced this issue Sep 16, 2022
@GiudGiud
Address Josh's review:
a7c6df6 
- move FPMat PH to a test object
- remove unecessary AD TFP routines which were stolent from SFP anyway
- remove name() from error calls as it s output anyway
- clean up TFP_ve test
- move util page out of syntax
Refs idaholab#20101
GiudGiud added a commit to licharlot/moose that referenced this issue Sep 16, 2022
@GiudGiud
Address Josh's review
546514c 
- simplify tabulated ve test
- fix units in fluid properties material
- improve formatting of TFP documentation
- dont refer to base class name in context of input files

Add SFP documentation page. It is rather reduced as the main index.md page is mostly SFP material
refs idaholab#20101
GiudGiud added a commit to licharlot/moose that referenced this issue Sep 16, 2022
@GiudGiud
Address Josh's review
f8c1fc1 
- simplify tabulated ve test
- fix units in fluid properties material
- improve formatting of TFP documentation
- dont refer to base class name in context of input files

Add SFP documentation page. It is rather reduced as the main index.md page is mostly SFP material
refs idaholab#20101
GiudGiud added a commit to licharlot/moose that referenced this issue Sep 16, 2022
@GiudGiud
Address Josh's review
0f2ab93 
- simplify tabulated ve test
- fix units in fluid properties material
- improve formatting of TFP documentation
- dont refer to base class name in context of input files

Add SFP documentation page. It is rather reduced as the main index.md page is mostly SFP material
refs idaholab#20101
GiudGiud added a commit to licharlot/moose that referenced this issue Sep 16, 2022
@GiudGiud
Address Josh's review
11b00b0 
- simplify tabulated ve test
- fix units in fluid properties material
- improve formatting of TFP documentation
- dont refer to base class name in context of input files

Add SFP documentation page. It is rather reduced as the main index.md page is mostly SFP material
refs idaholab#20101
GiudGiud added a commit to licharlot/moose that referenced this issue Sep 16, 2022
@GiudGiud
Address Josh's review
101ba97 
- simplify tabulated ve test
- fix units in fluid properties material
- improve formatting of TFP documentation
- dont refer to base class name in context of input files

Add SFP documentation page. It is rather reduced as the main index.md page is mostly SFP material
refs idaholab#20101
GiudGiud added a commit to licharlot/moose that referenced this issue Sep 17, 2022
@GiudGiud
Add parameter groups to TabulatedFluidProperties, refs idaholab#20101
0e35659
GiudGiud added a commit to licharlot/moose that referenced this issue Sep 19, 2022
@GiudGiud
Address Josh'review
58b664d 
- utils doc formatting
Refs idaholab#20101
GiudGiud added a commit to licharlot/moose that referenced this issue Sep 19, 2022
@GiudGiud
Address Josh'review
a88acce 
- utils doc formatting
Refs idaholab#20101
@GiudGiud
Copy link
Contributor

Closed by #22060

GiudGiud added a commit to GiudGiud/moose that referenced this issue Jun 14, 2023
@GiudGiud
Add rho_from_p_s to TFP
3c2964d 
refs idaholab#20101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Modules/Fluid Properties Tickets pertaining to the fluid_properties module T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@veeshy @snschune @loganharbour @GiudGiud