Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FancyExtruderGenerator should protect against mixed positive/negative layer heights #21273

Closed
aprilnovak opened this issue Jun 10, 2022 · 0 comments · Fixed by #21274
Closed
Labels
T: task An enhancement to the software.

Comments

@aprilnovak
Copy link
Contributor

Reason

I use scripts to make meshes, and sometimes make a mistake with my fparse math and end up with a mix of positive and negative layer heights in FancyExtruderGenerator. This messes up the mesh and causes layers to overlap. I'm assuming the behavior should be to error rather than allow this.

Design

Throw an error if the user mixes positive and negative elements in heights.

Impact

Better user experience.

@aprilnovak aprilnovak added the T: task An enhancement to the software. label Jun 10, 2022
aprilnovak added a commit to aprilnovak/moose that referenced this issue Jun 10, 2022
crb3874 pushed a commit to crb3874/moose_colin that referenced this issue Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: task An enhancement to the software.
Projects
None yet
1 participant