Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temperature pressure function fluid properties #21505

Open
CalfSteven opened this issue Jul 5, 2022 · 0 comments
Open

Temperature pressure function fluid properties #21505

CalfSteven opened this issue Jul 5, 2022 · 0 comments
Labels
C: Modules/Fluid Properties Tickets pertaining to the fluid_properties module T: task An enhancement to the software.

Comments

@CalfSteven
Copy link
Contributor

CalfSteven commented Jul 5, 2022 •
edited

Reason
Temperature pressure function fluid property is a convenient fluid property to use across the different modules.

Design
A new fluid property, in the fluid properties module. All properties should be defined using the Function.

Impact
Increased usability and flexibility.
@CalfSteven CalfSteven added the T: task An enhancement to the software. label Jul 5, 2022
@GiudGiud GiudGiud changed the title Temperature pressure function Temperature pressure function fluid properties Jul 5, 2022
@GiudGiud GiudGiud added the C: Modules/Fluid Properties Tickets pertaining to the fluid_properties module label Jul 5, 2022
CalfSteven added a commit to CalfSteven/moose that referenced this issue Jul 7, 2022
@CalfSteven
Add temperature pressure function fluid property
dc37451 
refs idaholab#21505
CalfSteven added a commit to CalfSteven/moose that referenced this issue Jul 7, 2022
@CalfSteven
Add test for temperature function fluidprop
f26bf38 
refs idaholab#21505
CalfSteven added a commit to CalfSteven/moose that referenced this issue Jul 7, 2022
@CalfSteven
Initialize functions later in PTFunctionFP because functions are cons…
c67791f 
…tructured after FPs

ref idaholab#21505
CalfSteven added a commit to CalfSteven/moose that referenced this issue Jul 7, 2022
@CalfSteven
Initialize functions later in PTFunctionFP because functions are cons…
6dd9d08 
…tructured after FPs

ref idaholab#21505
GiudGiud pushed a commit to CalfSteven/moose that referenced this issue Mar 6, 2023
@CalfSteven @GiudGiud
Add temperature pressure function fluid property
78b088f 
refs idaholab#21505
GiudGiud pushed a commit to CalfSteven/moose that referenced this issue Mar 6, 2023
@CalfSteven @GiudGiud
Add test for temperature function fluidprop
fabd480 
refs idaholab#21505
GiudGiud pushed a commit to CalfSteven/moose that referenced this issue Mar 6, 2023
@CalfSteven @GiudGiud
Initialize functions later in PTFunctionFP because functions are cons…
78a6e67 
…tructured after FPs

ref idaholab#21505
GiudGiud added a commit to CalfSteven/moose that referenced this issue Mar 6, 2023
@GiudGiud
Minor test cleanup
99d0d98 
refs idaholab#21505
GiudGiud added a commit to CalfSteven/moose that referenced this issue Mar 7, 2023
@GiudGiud
Fix various issues with TPFuctionFP:
76b9770 
- cp and cv both constant is not physical
- fixup some derivatives
refs idaholab#21505
GiudGiud added a commit to CalfSteven/moose that referenced this issue Mar 7, 2023
@GiudGiud
Add limitations for cp computation in documentation
3f11158 
Rework documentation so it actually makes sense
Straight up say we dont support the conservative variables because we are missing too many routines
refs idaholab#21505
GiudGiud added a commit to CalfSteven/moose that referenced this issue Mar 7, 2023
@GiudGiud
Fix derivatives of cp for TPFunctionProps
2d270e2 
Add derivatives for h
Fix docstrings for cp/cv and derivatives
Add some easy cv routines since it s constant
refs idaholab#21505
GiudGiud added a commit to CalfSteven/moose that referenced this issue Mar 7, 2023
@GiudGiud
Add routine name in newton inversion of fluid properties to have more…
8f5f2b1 
… informative error messages and warning

refs idaholab#21505
GiudGiud added a commit to CalfSteven/moose that referenced this issue Mar 7, 2023
@GiudGiud
Add unit test for TPFunctionFP properties
1b69afa 
refs idaholab#21505
GiudGiud added a commit to CalfSteven/moose that referenced this issue Mar 7, 2023
@GiudGiud
Rework regression test to be more simple
aec4fef 
refs idaholab#21505
GiudGiud added a commit to CalfSteven/moose that referenced this issue Mar 7, 2023
@GiudGiud
Add a boolean to be able to test fluid properties that dont have the …
7f81756 
…full set of props implemented, notably s and c that are only used in THM & CNSFV

refs idaholab#21505
GiudGiud added a commit to CalfSteven/moose that referenced this issue Mar 7, 2023
@GiudGiud
Use e_from_p_T before trying to use e_from_p_rho for converting fluid…
9a2fbad 
… properties:

- more likely to be implemented (arguable)
refs idaholab#21505
GiudGiud added a commit to CalfSteven/moose that referenced this issue Mar 7, 2023
@GiudGiud
Explicitly error on s_from_p_T calls for TPFunctionFP
cebb5d1 
We do not want to rely on the SinglePhaseFP behavior which infinitely chains s_from_p_T and s_from_v_e calls
refs idaholab#21505
GiudGiud added a commit to CalfSteven/moose that referenced this issue Mar 7, 2023
@GiudGiud
Further rework regression test:
319f48d 
- test all properties we know analytically
- just retrieve properties we dont know
refs idaholab#21505
GiudGiud added a commit to CalfSteven/moose that referenced this issue Mar 7, 2023
@GiudGiud
Force developer to include the name of the routines for the NewtonSol…
2b68575 
…ve in 1D for better error messages

Fix build error with shadowing of AD routines

Update modules/fluid_properties/doc/content/source/userobjects/TemperaturePressureFunctionFluidProperties.md
refs idaholab#21505
GiudGiud added a commit to CalfSteven/moose that referenced this issue Mar 7, 2023
@GiudGiud
Use a bool to keep track of function retrieval in TPFunctionFP
a845e2c 
refs idaholab#21505
GiudGiud added a commit to CalfSteven/moose that referenced this issue Mar 7, 2023
@GiudGiud
Use a bool to keep track of function retrieval in TPFunctionFP
40a5fe6 
refs idaholab#21505
GiudGiud added a commit to CalfSteven/moose that referenced this issue Mar 7, 2023
@GiudGiud
Further rework regression test:
38cff2b 
- test all properties we know analytically
- just retrieve properties we dont know
refs idaholab#21505
GiudGiud added a commit to CalfSteven/moose that referenced this issue Mar 7, 2023
@GiudGiud
Force developer to include the name of the routines for the NewtonSol…
66de9b1 
…ve in 1D for better error messages

Fix build error with shadowing of AD routines

Update modules/fluid_properties/doc/content/source/userobjects/TemperaturePressureFunctionFluidProperties.md
refs idaholab#21505
GiudGiud added a commit to CalfSteven/moose that referenced this issue Mar 7, 2023
@GiudGiud
Use a bool to keep track of function retrieval in TPFunctionFP
f6b6a8d 
refs idaholab#21505
GiudGiud pushed a commit to CalfSteven/moose that referenced this issue Mar 7, 2023
@CalfSteven @GiudGiud
Initialize functions later in PTFunctionFP because functions are cons…
4631ba9 
…tructured after FPs

ref idaholab#21505
GiudGiud added a commit to CalfSteven/moose that referenced this issue Mar 7, 2023
@GiudGiud
Minor test cleanup
e6894bf 
refs idaholab#21505
GiudGiud added a commit to CalfSteven/moose that referenced this issue Mar 7, 2023
@GiudGiud
Fix various issues with TPFuctionFP:
fc7a294 
- cp and cv both constant is not physical
- fixup some derivatives
refs idaholab#21505
GiudGiud added a commit to CalfSteven/moose that referenced this issue Mar 7, 2023
@GiudGiud
Add limitations for cp computation in documentation
a094a10 
Rework documentation so it actually makes sense
Straight up say we dont support the conservative variables because we are missing too many routines
refs idaholab#21505
GiudGiud added a commit to CalfSteven/moose that referenced this issue Mar 7, 2023
@GiudGiud
Fix derivatives of cp for TPFunctionProps
2f82be4 
Add derivatives for h
Fix docstrings for cp/cv and derivatives
Add some easy cv routines since it s constant
refs idaholab#21505
GiudGiud added a commit to CalfSteven/moose that referenced this issue Mar 7, 2023
@GiudGiud
Add routine name in newton inversion of fluid properties to have more…
49707aa 
… informative error messages and warning

refs idaholab#21505
GiudGiud added a commit to CalfSteven/moose that referenced this issue Mar 7, 2023
@GiudGiud
Add unit test for TPFunctionFP properties
9c9fdb4 
refs idaholab#21505
GiudGiud added a commit to CalfSteven/moose that referenced this issue Mar 7, 2023
@GiudGiud
Rework regression test to be more simple
e7c17f0 
refs idaholab#21505
GiudGiud added a commit to CalfSteven/moose that referenced this issue Mar 7, 2023
@GiudGiud
Add a boolean to be able to test fluid properties that dont have the …
5db1f62 
…full set of props implemented, notably s and c that are only used in THM & CNSFV

refs idaholab#21505
GiudGiud added a commit to CalfSteven/moose that referenced this issue Mar 7, 2023
@GiudGiud
Use e_from_p_T before trying to use e_from_p_rho for converting fluid…
ee4ce50 
… properties:

- more likely to be implemented (arguable)
refs idaholab#21505
GiudGiud added a commit to CalfSteven/moose that referenced this issue Mar 7, 2023
@GiudGiud
Explicitly error on s_from_p_T calls for TPFunctionFP
6d6c622 
We do not want to rely on the SinglePhaseFP behavior which infinitely chains s_from_p_T and s_from_v_e calls
refs idaholab#21505
GiudGiud added a commit to CalfSteven/moose that referenced this issue Mar 7, 2023
@GiudGiud
Further rework regression test:
4c9e7dd 
- test all properties we know analytically
- just retrieve properties we dont know
refs idaholab#21505
GiudGiud added a commit to CalfSteven/moose that referenced this issue Mar 7, 2023
@GiudGiud
Force developer to include the name of the routines for the NewtonSol…
55b508d 
…ve in 1D for better error messages

Fix build error with shadowing of AD routines

Update modules/fluid_properties/doc/content/source/userobjects/TemperaturePressureFunctionFluidProperties.md
refs idaholab#21505
GiudGiud added a commit to CalfSteven/moose that referenced this issue Mar 7, 2023
@GiudGiud
Use a bool to keep track of function retrieval in TPFunctionFP
a3fe2f8 
refs idaholab#21505
GiudGiud added a commit to GiudGiud/moose that referenced this issue Mar 21, 2024
@GiudGiud
Add a clear example of using the PT function FP
4f2826e 
refs idaholab#21505
@GiudGiud GiudGiud mentioned this issue Mar 21, 2024
Merged
GiudGiud added a commit to GiudGiud/moose that referenced this issue Mar 21, 2024
@GiudGiud @joshuahansel
Add a clear example of using the PT function FP
ca5736f 
refs idaholab#21505

Apply suggestions from code review

Co-authored-by: joshuahansel <joshua.hansel@inl.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Modules/Fluid Properties Tickets pertaining to the fluid_properties module T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GiudGiud @CalfSteven