Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make action parameters also controllable #22068

Closed
YaqiWang opened this issue Sep 11, 2022 · 1 comment · Fixed by #22069
Closed

Make action parameters also controllable #22068

YaqiWang opened this issue Sep 11, 2022 · 1 comment · Fixed by #22069
Labels
C: Framework T: task An enhancement to the software.

Comments

@YaqiWang
Copy link
Contributor

Reason

It is desired to change certain parameters in an input file during the calculation. This can be achieved with controllable parameter capability. However, currently, only objects derived from MooseObject can have controllable parameters. A large portion of input syntax with Actions cannot have controllable parameters. A parameter in an action might be used for constructing bunch of moose objects, it will be up to action developers to connect the controllable parameter in an action with the parameters of all the depending moose objects, which has been a capability in the input parameter warehouse.

Design

To achieve this, we will first need to make the parameters of various actions held by the InputParameterWarehouse like the moose objects but instead of the action itself, and change the constructor interface from

  Action(InputParameters parameters);

to

  Action(const InputParameters & parameters);

This will be a relative large change in interface and will affect all applications.

Impact

A new capability.

@YaqiWang YaqiWang added the T: task An enhancement to the software. label Sep 11, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 11, 2022
… input parameter warehouse to keep the action parameters idaholab#22068
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 12, 2022
… input parameter warehouse to keep the action parameters idaholab#22068
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 12, 2022
@loganharbour
Copy link
Member

I think this is a pretty significant change that needs to be discussed further

YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 12, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 12, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 12, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 12, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 13, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 13, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 13, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 13, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 13, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 13, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 13, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 13, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 13, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 13, 2022
… input parameter warehouse to keep the action parameters idaholab#22068
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 13, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 13, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 13, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 13, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 13, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 13, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 13, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 13, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 13, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 13, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 13, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 14, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 14, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 14, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 15, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 15, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 15, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 15, 2022
… input parameter warehouse to keep the action parameters idaholab#22068
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 15, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 15, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 15, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 15, 2022
YaqiWang added a commit to YaqiWang/moose that referenced this issue Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Framework T: task An enhancement to the software.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants