Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect transfer of data from displaced source #22534

Closed
lindsayad opened this issue Oct 28, 2022 · 4 comments · Fixed by #22538
Closed

Incorrect transfer of data from displaced source #22534

lindsayad opened this issue Oct 28, 2022 · 4 comments · Fixed by #22538
Assignees
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.

Comments

@lindsayad
Copy link
Member

lindsayad commented Oct 28, 2022

Bug Description

Executing the inputs contained on my branch debugging-22119, which stems from discussion #22119 leads to the following undesirable behavior:

  • libMesh node ID 89365 (exodus node ID 89366) is an example of a to-node getting a 0 value when it shouldn't
  • This corresponds to the 4833 point that we want to query the from-mesh for (e.g. index 4832 in the incoming/outgoing points vector)
  • When asking the mesh function to find the from-element containing that to-node we are getting back a null result, indicating that it thinks the point is out of the mesh
  • When we get to the active nodes in TreeNode, we do get bounds_point but we do not get any elements that contains_point

I don't really know why this would be a hard case ... these are linear elements so I would expect inverse mapping from the physical space to the reference space to essentially be exact.

@roystgnr do you have any thoughts on what might be the issue here? Pasted below is a figure. The bottom is the sub-application field that we are transferring to the main application on top. You can see that we are getting these "teeth" in the transfer with the blue gaps in the teeth essentially indicating a failed transfer
Screen Shot 2022-10-28 at 12 35 44 AM

Steps to Reproduce

Run the parent.i input in my branch

Impact

Incorrect data transfers from displaced meshes. Erodes trust in the transfer system

@lindsayad lindsayad added T: defect An anomaly, which is anything that deviates from expectations. P: normal A defect affecting operation with a low possibility of significantly affects. C: Framework labels Oct 28, 2022
@lindsayad lindsayad self-assigned this Oct 28, 2022
@lindsayad
Copy link
Member Author

We can definitely verify that we have an elem->contains_point within the displaced mesh, so what gives ...
Screenshot from 2022-10-28 14-06-33

@lindsayad
Copy link
Member Author

libMesh Elem ID is 5323 (Exodus ID 5324)

@lindsayad
Copy link
Member Author

@maxnezdyur I think this looks better, eh?
Screen Shot 2022-10-28 at 2 57 57 PM

@maxnezdyur
Copy link
Contributor

A lot better!

lindsayad added a commit to lindsayad/moose that referenced this issue Oct 28, 2022
Displacing the mesh invalidates all the bounding boxes on the
point locator, so we need to make sure we clear the locator so
we don't use bad bounding box data

Closes idaholab#22534
lindsayad added a commit to lindsayad/moose that referenced this issue Oct 31, 2022
Displacing the mesh invalidates all the bounding boxes on the
point locator, so we need to make sure we clear the locator so
we don't use bad bounding box data

Closes idaholab#22534
lindsayad added a commit to lindsayad/moose that referenced this issue Oct 31, 2022
Displacing the mesh invalidates all the bounding boxes on the
point locator, so we need to make sure we clear the locator so
we don't use bad bounding box data

Closes idaholab#22534
lindsayad added a commit to lindsayad/moose that referenced this issue Nov 1, 2022
Displacing the mesh invalidates all the bounding boxes on the
point locator, so we need to make sure we clear the locator so
we don't use bad bounding box data

Closes idaholab#22534
lindsayad added a commit to lindsayad/moose that referenced this issue Nov 1, 2022
Displacing the mesh invalidates all the bounding boxes on the
point locator, so we need to make sure we clear the locator so
we don't use bad bounding box data

Closes idaholab#22534
maxnezdyur pushed a commit to maxnezdyur/moose that referenced this issue Feb 12, 2023
Displacing the mesh invalidates all the bounding boxes on the
point locator, so we need to make sure we clear the locator so
we don't use bad bounding box data

Closes idaholab#22534
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants