Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugs in assembling Jacobian with array variables #23123

Closed
YaqiWang opened this issue Jan 10, 2023 · 0 comments · Fixed by #23124
Closed

Bugs in assembling Jacobian with array variables #23123

YaqiWang opened this issue Jan 10, 2023 · 0 comments · Fixed by #23124
Labels
P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.

Comments

@YaqiWang
Copy link
Contributor

Bug Description

These bugs were discovered by Namjae when he tried to use a custom Griffin executioner which uses ComputeJacobianBlocksThread to assemble the block-diagonal matrix. ComputeJacobianBlocksThread calls FEProblemBase::addJacobianBlockTags, which calls Assembly::addJacobianBlock, by passing in a libMesh variable number for any component of array variables. Current code in Assembly::addJacobianBlock assumes the variable number passed in is the libMesh variable number of the 0-th component. Another bug is in Assembly::saveFullLocalArrayJacobian which is called through either ComputeJacobianBlocksThread or ComputeFullJacobianThread through kernel/bc computeOffDiagJacobian function. The case with component block diagonal is handled wrongly.

Steps to Reproduce

After fixing those two bugs, the test in Griffin can run properly. I will push the fix in first and see whether I can come up with a MOOSE test for the fix.

Impact

Fixing bugs that can show up in corner cases.
@YaqiWang YaqiWang added P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations. labels Jan 10, 2023
YaqiWang added a commit to YaqiWang/moose that referenced this issue Jan 10, 2023
@YaqiWang
fix the two bugs in assembly with array variables idaholab#23123
f78105b
@YaqiWang YaqiWang mentioned this issue Jan 10, 2023
Merged
YaqiWang added a commit to YaqiWang/moose that referenced this issue Jan 10, 2023
@YaqiWang
extend SMP a little so that it can support testing jacobian assembly …
76355eb 
…with array variables idaholab#23123
YaqiWang added a commit to YaqiWang/moose that referenced this issue Jan 10, 2023
@YaqiWang
add a test that showing the jacobian assembly bug reported in idahola…
e1c882e 
…b#23123
YaqiWang added a commit to YaqiWang/moose that referenced this issue Jan 10, 2023
@YaqiWang
fix the two bugs in assembly with array variables idaholab#23123
c430c79
YaqiWang added a commit to YaqiWang/moose that referenced this issue Jan 10, 2023
@YaqiWang
add a test that showing the jacobian assembly bug reported in idahola…
57125e5 
…b#23123
YaqiWang added a commit to YaqiWang/moose that referenced this issue Jan 10, 2023
@YaqiWang
fix the two bugs in assembly with array variables idaholab#23123
3f16f34
YaqiWang added a commit to YaqiWang/moose that referenced this issue Jan 11, 2023
@YaqiWang
add a test that showing the jacobian assembly bug reported in idahola…
a1b6d81 
…b#23123
YaqiWang added a commit to YaqiWang/moose that referenced this issue Jan 11, 2023
@YaqiWang
fix the two bugs in assembly with array variables idaholab#23123
0f92096
YaqiWang added a commit to YaqiWang/moose that referenced this issue Jan 12, 2023
@YaqiWang
add a test that showing the jacobian assembly bug reported in idahola…
5554773 
…b#23123
YaqiWang added a commit to YaqiWang/moose that referenced this issue Jan 12, 2023
@YaqiWang
fix the two bugs in assembly with array variables idaholab#23123
9cc1d96
YaqiWang added a commit to YaqiWang/moose that referenced this issue Jan 12, 2023
@YaqiWang
extend PBP a little so that it can support testing jacobian assembly …
f640960 
…with array variables idaholab#23123
YaqiWang added a commit to YaqiWang/moose that referenced this issue Jan 12, 2023
@YaqiWang
fix the bug with the variable number being a number of a non-zeroth c…
ac29b36 
…omponent number of an array variable idaholab#23123
YaqiWang added a commit to YaqiWang/moose that referenced this issue Jan 12, 2023
@YaqiWang
add a test that showing the jacobian assembly bug reported in idahola…
f68c959 
…b#23123
YaqiWang added a commit to YaqiWang/moose that referenced this issue Jan 12, 2023
@YaqiWang
fix a bug that shows up when diagonal coupling is turned on with arra…
7555390 
…y variables idaholab#23123
MengnanLi91 pushed a commit to MengnanLi91/moose that referenced this issue Jan 18, 2023
@YaqiWang @MengnanLi91
extend SMP a little so that it can support testing jacobian assembly …
d17147f 
…with array variables idaholab#23123
MengnanLi91 pushed a commit to MengnanLi91/moose that referenced this issue Jan 18, 2023
@YaqiWang @MengnanLi91
extend PBP a little so that it can support testing jacobian assembly …
e0349ca 
…with array variables idaholab#23123
MengnanLi91 pushed a commit to MengnanLi91/moose that referenced this issue Jan 18, 2023
@YaqiWang @MengnanLi91
fix the bug with the variable number being a number of a non-zeroth c…
ce53821 
…omponent number of an array variable idaholab#23123
MengnanLi91 pushed a commit to MengnanLi91/moose that referenced this issue Jan 18, 2023
@YaqiWang @MengnanLi91
add a test that showing the jacobian assembly bug reported in idahola…
89baa71 
…b#23123
MengnanLi91 pushed a commit to MengnanLi91/moose that referenced this issue Jan 18, 2023
@YaqiWang @MengnanLi91
fix a bug that shows up when diagonal coupling is turned on with arra…
3b93971 
…y variables idaholab#23123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the two bugs in assembly with array variables YaqiWang/moose
1 participant
@YaqiWang