Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the user to specify not (yet) existing subdomain IDs as valid #23557

Closed
dschwen opened this issue Feb 28, 2023 · 1 comment · Fixed by #23597
Closed

Allow the user to specify not (yet) existing subdomain IDs as valid #23557

dschwen opened this issue Feb 28, 2023 · 1 comment · Fixed by #23597
Labels
C: Meshing MeshGenerator system, mesh loading T: task An enhancement to the software.

Comments

@dschwen
Copy link
Member

dschwen commented Feb 28, 2023

Reason

With dynamic subdomain changes needed for AM or element death simulations, we often run into the limitation that the set of valid subdomains is the set of subdomains existing on the initial mesh. However at t=0 no element might be in the deleted subdomain.

We currently circumvent this by having a free floating element unconnected to the mesh, with the needed subdomain id.

Design

I propose a new parameter

Mesh/add_subdomain_id = 9999

that lets the user specify a list of IDs that are assumed to be valid. That will permit the user to set up block restrictions for this yet non-existing subdomain in their inputs.

Impact

Simplified capability.

Ping @bwspenc

@dschwen dschwen added the T: task An enhancement to the software. label Feb 28, 2023
dschwen added a commit to dschwen/moose that referenced this issue Mar 1, 2023
@GiudGiud GiudGiud added the C: Meshing MeshGenerator system, mesh loading label Mar 2, 2023
@GiudGiud
Copy link
Contributor

GiudGiud commented Mar 2, 2023

We've been going the other way for this, to reduce user input error we have banned more and more ids and names that are not in the initial mesh.

A system to allow pre-declaring future stuff makes a lot of sense though

dschwen added a commit to dschwen/moose that referenced this issue Mar 3, 2023
dschwen added a commit to dschwen/moose that referenced this issue Mar 3, 2023
dschwen added a commit to dschwen/moose that referenced this issue Mar 3, 2023
@dschwen dschwen mentioned this issue Mar 3, 2023
dschwen added a commit to dschwen/moose that referenced this issue Mar 3, 2023
Co-authored-by: Alex Lindsay <alexlindsay239@gmail.com>
dschwen added a commit to dschwen/moose that referenced this issue Mar 3, 2023
Co-authored-by: Alex Lindsay <alexlindsay239@gmail.com>
dschwen added a commit to dschwen/moose that referenced this issue Mar 3, 2023
Co-authored-by: Alex Lindsay <alexlindsay239@gmail.com>
dschwen added a commit to dschwen/moose that referenced this issue Mar 3, 2023
Co-authored-by: Alex Lindsay <alexlindsay239@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Meshing MeshGenerator system, mesh loading T: task An enhancement to the software.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants