Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow post-processors to be used in functor parameters #25012

Closed
joshuahansel opened this issue Jul 21, 2023 · 0 comments · Fixed by #25188
Closed

Allow post-processors to be used in functor parameters #25012

joshuahansel opened this issue Jul 21, 2023 · 0 comments · Fixed by #25188
Labels
C: Framework T: task An enhancement to the software.

Comments

@joshuahansel
Copy link
Contributor

Reason

It's sometimes useful to pass post-processors in for parameters of type MooseFunctorName.

Design

This would allow post-processors to be used in parameters of type MooseFunctorName.

Impact

No change to existing input files. Greater flexibility.
@joshuahansel joshuahansel added C: Framework T: task An enhancement to the software. labels Jul 21, 2023
joshuahansel added a commit to joshuahansel/moose that referenced this issue Aug 11, 2023
@joshuahansel
Allowed post-processors to be used in functor parameters
0a5f62a 
Closes idaholab#25012
@joshuahansel joshuahansel mentioned this issue Aug 11, 2023
Merged
joshuahansel added a commit to joshuahansel/moose that referenced this issue Aug 14, 2023
@joshuahansel
Allowed post-processors to be used in functor parameters
fa21cd2 
Closes idaholab#25012
joshuahansel added a commit to joshuahansel/moose that referenced this issue Aug 16, 2023
@joshuahansel
Allowed post-processors to be used in functor parameters
09ee070 
Closes idaholab#25012
joshuahansel added a commit to joshuahansel/magpie that referenced this issue Aug 16, 2023
@joshuahansel
Qualified dot() base class in TemporalCorrelation
1949829 
Post-processors will become functors, which have a dot() method,
so there would be two dot() methods for objects inheriting from
MooseVariableInterface..

Refs idaholab/moose#25012
joshuahansel added a commit to joshuahansel/moose that referenced this issue Aug 16, 2023
@joshuahansel
Allowed post-processors to be used in functor parameters
6046134 
Closes idaholab#25012
loganharbour added a commit to loganharbour/moose that referenced this issue Aug 16, 2023
@loganharbour
Simplify current value, add docstrings, rename method
e0d5f65 
- Adds lots of documentation as to getValue vs getCurrentValue
- Removes unnecessary headers
- Stores the value at construction time instead of doing a map lookup
- Moves extraneous methods to source

refs idaholab#25012
joshuahansel added a commit to joshuahansel/moose that referenced this issue Aug 17, 2023
@joshuahansel
Added tests for PP functor dot and gradient
d99f314 
Refs idaholab#25012
joshuahansel added a commit to joshuahansel/moose that referenced this issue Aug 18, 2023
@joshuahansel
Fixed test and addressed comments
e7c63c5 
Refs idaholab#25012
joshuahansel added a commit to joshuahansel/moose that referenced this issue Aug 21, 2023
@joshuahansel
Overrode Postprocessor::hasBlocks() for use as functors
aa3810f 
Refs idaholab#25012
oanaoana pushed a commit to oanaoana/moose that referenced this issue Oct 19, 2023
@joshuahansel @oanaoana
Allowed post-processors to be used in functor parameters
8f89725 
Closes idaholab#25012
oanaoana pushed a commit to oanaoana/moose that referenced this issue Oct 19, 2023
@loganharbour @oanaoana
Simplify current value, add docstrings, rename method
53cc592 
- Adds lots of documentation as to getValue vs getCurrentValue
- Removes unnecessary headers
- Stores the value at construction time instead of doing a map lookup
- Moves extraneous methods to source

refs idaholab#25012
oanaoana pushed a commit to oanaoana/moose that referenced this issue Oct 19, 2023
@joshuahansel @oanaoana
Added tests for PP functor dot and gradient
8ffdf9f 
Refs idaholab#25012
oanaoana pushed a commit to oanaoana/moose that referenced this issue Oct 19, 2023
@joshuahansel @oanaoana
Fixed test and addressed comments
8e1b594 
Refs idaholab#25012
oanaoana pushed a commit to oanaoana/moose that referenced this issue Oct 19, 2023
@joshuahansel @oanaoana
Overrode Postprocessor::hasBlocks() for use as functors
1f838ee 
Refs idaholab#25012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Framework T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allowed post-processors to be used in functor parameters joshuahansel/moose
1 participant
@joshuahansel