Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to Parsed generation of sidesets to only include external ones #25082

Closed
GiudGiud opened this issue Aug 2, 2023 · 2 comments · Fixed by #25084
Closed

Add an option to Parsed generation of sidesets to only include external ones #25082

GiudGiud opened this issue Aug 2, 2023 · 2 comments · Fixed by #25084
Assignees
@GiudGiud
Labels
C: Meshing MeshGenerator system, mesh loading T: task An enhancement to the software.

Comments

@GiudGiud
Copy link
Contributor

GiudGiud commented Aug 2, 2023 •
edited by dschwen

Reason

When adding a boundary, if the surface is curved it s sometimes exceedingly difficult to get the outside of the surface without grabbing one or more sides
We can make due currently if we re lucky enough to be able to rely on subdomain and neighbor subdomains. But if there's no neighbor subdomains (truly external face) then there's nothing in ParsedGenerateSideset

Design

Simple additional boolean to disable adding internal ones

Impact

Easier MOOSE meshing
More usability
@GiudGiud GiudGiud added T: task An enhancement to the software. C: Meshing MeshGenerator system, mesh loading labels Aug 2, 2023
@GiudGiud GiudGiud self-assigned this Aug 2, 2023
@dschwen
Copy link
Member

dschwen commented Aug 2, 2023

Something along the lines of https://github.com/idaholab/moose/pull/23468/files , but for ParsedGenerateSideset. 👍

@GiudGiud
Copy link
Contributor Author

GiudGiud commented Aug 2, 2023

Exactly!

GiudGiud added a commit to GiudGiud/moose that referenced this issue Aug 2, 2023
@GiudGiud
Add an option to only consider external sides when building sidesets, c…
8c09779 
…loses idaholab#25082
GiudGiud added a commit to GiudGiud/moose that referenced this issue Aug 2, 2023
@GiudGiud
Add a test for considering only external sides, refs idaholab#25082
0d5b1f5
@GiudGiud GiudGiud mentioned this issue Aug 2, 2023
Merged
GiudGiud added a commit to GiudGiud/moose that referenced this issue Aug 2, 2023
@GiudGiud @lindsayad
Add an option to only consider external sides when building sidesets, c…
fcbf17c 
…loses idaholab#25082

Update framework/src/meshgenerators/ParsedGenerateSideset.C

Co-authored-by: Alex Lindsay <alexander.lindsay@inl.gov>
GiudGiud added a commit to GiudGiud/moose that referenced this issue Aug 2, 2023
@GiudGiud
Add a test for considering only external sides, refs idaholab#25082
9de82f9
oanaoana pushed a commit to oanaoana/moose that referenced this issue Oct 19, 2023
@GiudGiud @lindsayad @oanaoana
Add an option to only consider external sides when building sidesets, c…
35fc42e 
…loses idaholab#25082

Update framework/src/meshgenerators/ParsedGenerateSideset.C

Co-authored-by: Alex Lindsay <alexander.lindsay@inl.gov>
oanaoana pushed a commit to oanaoana/moose that referenced this issue Oct 19, 2023
@GiudGiud @oanaoana
Add a test for considering only external sides, refs idaholab#25082
7f2fa20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GiudGiud GiudGiud

Labels
C: Meshing MeshGenerator system, mesh loading T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only consider external sides on parsed sideset generation GiudGiud/moose
2 participants
@dschwen @GiudGiud