Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed execute_on for PPs and scalars in CSV leads to bad output #25211

Open
joshuahansel opened this issue Aug 15, 2023 · 1 comment
Open

Mixed execute_on for PPs and scalars in CSV leads to bad output #25211

joshuahansel opened this issue Aug 15, 2023 · 1 comment
Assignees
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.

Comments

@joshuahansel
Copy link
Contributor

Bug Description

When a simulation has both scalar variables and PPs and uses CSV output and the values for execute_scalars_on and execute_postprocessors_on are different, then the columns in the output file get messed up.

Steps to Reproduce

Run the following input file:
csv.txt
And observe the CSV output:

time,aux0_0,aux0_1,aux1,aux2
0,12,13,5,10
1,12,13,5,10
2,0,0,0,0,3,2

In the header row and 2 following rows, there are 5 columns (time plus 4 scalar variables). In the last row, there are 7 columns.

Impact

Incorrect output files, which can lead to incorrect interpretation of results.

@joshuahansel joshuahansel added C: Framework T: defect An anomaly, which is anything that deviates from expectations. P: normal A defect affecting operation with a low possibility of significantly affects. labels Aug 15, 2023
@joshuahansel
Copy link
Contributor Author

I'm guessing it's the same for reporters. I'm going to try throwing an error if any are different and see if any apps trigger it.

joshuahansel added a commit to joshuahansel/moose that referenced this issue Aug 15, 2023
joshuahansel added a commit to joshuahansel/moose that referenced this issue Aug 16, 2023
joshuahansel added a commit to joshuahansel/moose that referenced this issue Aug 17, 2023
joshuahansel added a commit to joshuahansel/moose that referenced this issue Aug 17, 2023
joshuahansel added a commit to joshuahansel/moose that referenced this issue Aug 17, 2023
oanaoana pushed a commit to oanaoana/moose that referenced this issue Oct 19, 2023
oanaoana pushed a commit to oanaoana/moose that referenced this issue Oct 19, 2023
oanaoana pushed a commit to oanaoana/moose that referenced this issue Oct 19, 2023
oanaoana pushed a commit to oanaoana/moose that referenced this issue Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.
Projects
None yet
Development

No branches or pull requests

1 participant